Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: pipe_tasks
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:DRP F17-1
-
Team:Data Release Production
Description
This causes coaddDriver to fail when bright object masks are turned on, e.g.
Traceback (most recent call last):
|
File "/software/lsstsw/stack/Linux64/ctrl_pool/13.0-4-g98e8074+2/python/lsst/ctrl/pool/parallel.py", line 495, in logOperation
|
yield
|
File "/software/lsstsw/stack/Linux64/pipe_drivers/13.0-5-g7e5c55c/python/lsst/pipe/drivers/coaddDriver.py", line 261, in coadd
|
coaddResults = self.assembleCoadd.run(patchRef, selectDataList)
|
File "/software/lsstsw/stack/Linux64/pipe_base/13.0-5-g0e05785/python/lsst/pipe/base/timer.py", line 121, in wrapper
|
res = func(self, *args, **keyArgs)
|
File "/software/lsstsw/stack/Linux64/pipe_tasks/13.0-31-gbcfe521/python/lsst/pipe/tasks/assembleCoadd.py", line 357, in run
|
self.setBrightObjectMasks(coaddExp, dataRef.dataId, brightObjectMasks)
|
File "/software/lsstsw/stack/Linux64/pipe_tasks/13.0-31-gbcfe521/python/lsst/pipe/tasks/assembleCoadd.py", line 788, in setBrightObjectMasks
|
foot = afwDetect.Footprint(center, radius, exposure.getBBox())
|
TypeError: __init__(): incompatible constructor arguments. The following argument types are supported:
|
1. lsst.afw.detection._footprint.Footprint(inputSpans: lsst.afw.geom.spanSet.SpanSet, region: lsst.afw.geom.box.Box2I=Box2D(minimum=Point2I(0, 0), dimensions=Extent2I(0, 0)))
|
2. lsst.afw.detection._footprint.Footprint(inputSpans: lsst.afw.geom.spanSet.SpanSet, peakSchema: lsst.afw.table.schema.schema.Schema, region: lsst.afw.geom.box.Box2I=Box2D(minimum=Point2I(0, 0), dimensions=Extent2I(0, 0)))
|
3. lsst.afw.detection._footprint.Footprint(arg0: lsst.afw.detection._footprint.Footprint)
|
4. lsst.afw.detection._footprint.Footprint()
|
|
Invoked with: Point2I(30655, 33041), 51.792857142857095, Box2D(minimum=Point2I(27900, 31900), dimensions=Extent2I(4200, 4100))
|
This should be covered in a unit test as well. Probably a good idea to do a quick scan for similar issues elsewhere too.
For the purposes of getting this fixed quickly, I'll opt not to add a unit test for this right now, but I do note for the future that setBrightObjectMasks should be tested at some point. Nate Lust can you look quickly at these few lines and confirm that I'm initializing the footprints correctly?