Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10797

Refactor meas_algorithms/objectSizeStarSelector to new BaseClass

    Details

      Attachments

        Issue Links

          Activity

          cmorrison Chris Morrison created issue -
          cmorrison Chris Morrison made changes -
          Field Original Value New Value
          Epic Link DM-9832 [ 31214 ]
          cmorrison Chris Morrison made changes -
          Link This issue clones DM-9839 [ DM-9839 ]
          Hide
          Parejkoj John Parejko added a comment -

          It turns out I have to do this to get DM-14155, because obs_sdss relies on objectSizeSS for measureApCorr, which was ported to the new API in DM-9832.

          Show
          Parejkoj John Parejko added a comment - It turns out I have to do this to get DM-14155 , because obs_sdss relies on objectSizeSS for measureApCorr, which was ported to the new API in DM-9832 .
          Parejkoj John Parejko made changes -
          Assignee Chris Morrison [ cmorrison ] John Parejko [ parejkoj ]
          Status To Do [ 10001 ] In Progress [ 3 ]
          Parejkoj John Parejko made changes -
          Risk Score 0
          Hide
          Parejkoj John Parejko added a comment -

          This is the remainder of the work on DM-9832, after I discovered that the CI packages (lsst_stack_demo, lsst_ci) were failing for various reasons. I had to convert two more of the StarSelectors to get CI to pass locally.

          Note that some of these PRs will be merged to the DM-9832 epic branch, before being merged to master, as they were based on that branch.

          Show
          Parejkoj John Parejko added a comment - This is the remainder of the work on DM-9832 , after I discovered that the CI packages (lsst_stack_demo, lsst_ci) were failing for various reasons. I had to convert two more of the StarSelectors to get CI to pass locally. Note that some of these PRs will be merged to the DM-9832 epic branch, before being merged to master, as they were based on that branch.
          Parejkoj John Parejko made changes -
          Reviewers Jim Bosch [ jbosch ]
          Status In Progress [ 3 ] In Review [ 10004 ]
          Show
          Parejkoj John Parejko added a comment - Jenkins run with all relevant tickets: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/27942/pipeline
          Hide
          jbosch Jim Bosch added a comment -

          Looks good; just one tiny doc comment on one PR.

          Does this obsolete obsolete any of DM-9837, DM-9838, and DM-9840?

           

          Show
          jbosch Jim Bosch added a comment - Looks good; just one tiny doc comment on one PR. Does this obsolete obsolete any of DM-9837 , DM-9838 , and DM-9840 ?  
          jbosch Jim Bosch made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]
          Hide
          Parejkoj John Parejko added a comment -

          9838 was done as part of this.

          I'm leaving 9837 and 9840 until later because I didn't need to do them to get the existing tests to pass. We'll get them soon enough though. We don't have an "exercise every thing in a registry" style of test, which could be useful to confirm that every item registered follows the API.

          Show
          Parejkoj John Parejko added a comment - 9838 was done as part of this. I'm leaving 9837 and 9840 until later because I didn't need to do them to get the existing tests to pass. We'll get them soon enough though. We don't have an "exercise every thing in a registry" style of test, which could be useful to confirm that every item registered follows the API.
          Hide
          Parejkoj John Parejko added a comment -

          Thanks for the quick review.

          Merged into 9832 and into master, and done!

          Show
          Parejkoj John Parejko added a comment - Thanks for the quick review. Merged into 9832 and into master, and done!
          Parejkoj John Parejko made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]
          hchiang2 Hsin-Fang Chiang made changes -
          Link This issue is triggering DM-14526 [ DM-14526 ]

            People

            • Assignee:
              Parejkoj John Parejko
              Reporter:
              cmorrison Chris Morrison
              Reviewers:
              Jim Bosch
              Watchers:
              Chris Morrison, Jim Bosch, John Parejko
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel