Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10804

Spatially-varying A&L decorrelation option

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ip_diffim
    • Labels:
      None

      Description

      Use ImageMapReduce to implement a spatially-varying A&L decorrelation task. Integrate that task as an option in imageDifference.py.

        Attachments

          Activity

          Hide
          reiss David Reiss added a comment - - edited

          Added a new "wrapper" task in ip_diffim: DecorrelateALKernelSpatialTask that is actually just a wrapper that can either run the "original" (non-spatially-varying) decorrelation task (DecorrelateALKernelTask), or else the spatially-varying one (via ImageMapReduceTask), given a `spatiallyVarying` option passed to its `run` method.

          Then basically dropped DecorrelateALKernelSpatialTask into imageDifference.py as a replacement for DecorrelateALKernelTask, with an additional (yes, sorry one more) config param - 'doSpatiallyVarying'. This will also be used when the Zogy task is integrated (DM-10805).

          Show
          reiss David Reiss added a comment - - edited Added a new "wrapper" task in ip_diffim: DecorrelateALKernelSpatialTask that is actually just a wrapper that can either run the "original" (non-spatially-varying) decorrelation task (DecorrelateALKernelTask), or else the spatially-varying one (via ImageMapReduceTask), given a `spatiallyVarying` option passed to its `run` method. Then basically dropped DecorrelateALKernelSpatialTask into imageDifference.py as a replacement for DecorrelateALKernelTask, with an additional (yes, sorry one more) config param - 'doSpatiallyVarying'. This will also be used when the Zogy task is integrated ( DM-10805 ).
          Hide
          reiss David Reiss added a comment -

          Also note, will need to rename 'gridSizeX/Y' in imageDecorrelation.py to 'cellSizeX/Y' on line 460 in order to sync with (and merge alongside) DM-10803.

          Show
          reiss David Reiss added a comment - Also note, will need to rename 'gridSizeX/Y' in imageDecorrelation.py to 'cellSizeX/Y' on line 460 in order to sync with (and merge alongside) DM-10803 .
          Hide
          reiss David Reiss added a comment -

          Chris! Would you mind reviewing this ticket? It is for integration of the spatially-varying image decorrelation task into `imageDifference.py`. See the notes I took on this ticket describing how it was done. Also note I added a unit test for the new wrapper task.

          Show
          reiss David Reiss added a comment - Chris! Would you mind reviewing this ticket? It is for integration of the spatially-varying image decorrelation task into `imageDifference.py`. See the notes I took on this ticket describing how it was done. Also note I added a unit test for the new wrapper task.
          Hide
          reiss David Reiss added a comment - - edited

          Verified `imageDifference.py` runs decorrelation with both doSpatialVariation = False and True (there is currently no unit test – DM-6386).

          Show
          reiss David Reiss added a comment - - edited Verified `imageDifference.py` runs decorrelation with both doSpatialVariation = False and True (there is currently no unit test – DM-6386 ).
          Hide
          reiss David Reiss added a comment - - edited
          Show
          reiss David Reiss added a comment - - edited Jenkins build complete: https://ci.lsst.codes/job/stack-os-matrix/24583/
          Hide
          reiss David Reiss added a comment -

          Thanks, Chris Morrison. Jenkins build verified, and merged.

          Show
          reiss David Reiss added a comment - Thanks, Chris Morrison . Jenkins build verified, and merged.

            People

            • Assignee:
              reiss David Reiss
              Reporter:
              reiss David Reiss
              Reviewers:
              Chris Morrison
              Watchers:
              Chris Morrison, David Reiss
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel