Data ManagementIcon indicating the project type

Data Management

Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10805

Spatially-varying ZOGY option

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ip_diffim
    • Labels:
      None

      Description

      Use ImageMapReduce to implement a spatially-varying A&L decorrelation task. Integrate that task as an option in imageDifference.py.

      Will possibly want to implement it as a subclass of ImagePsfMatchTask, because that task includes wrapper code for warping, which will be necessary here.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-11656 Fix ZOGY failure when PSFs are offset

          • In Progress

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-11654 Refactor ZogyPsfMatch and ImagePsfMatch to inherit from an ABC

          • Won't Fix

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-3704 Refactor ImageDifferenceTask: Split into two tasks

          • Won't Fix

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-5295 Refactor processDiffim

          • Won't Fix

            Activity

            Ascending order - Click to sort in descending order
            17 older comments
            Hide
            Permalink
            reiss David Reiss added a comment -

            I've updated the code in order to (hopefully) address all PSF sizing issues. I also added a unit test that explicitly checked for cases where the PSFs had different dimensions. This code is now checked in.

            I'll attempt to re-run your tests on lsst-dev now.

            Show
            reiss David Reiss added a comment - I've updated the code in order to (hopefully) address all PSF sizing issues. I also added a unit test that explicitly checked for cases where the PSFs had different dimensions. This code is now checked in. I'll attempt to re-run your tests on lsst-dev now.
            Hide
            Permalink
            reiss David Reiss added a comment -

            The refactoring of ZogyPsfMatchTask to inherit from an ABC (comment above) will be implemented in DM-11654.

            Show
            reiss David Reiss added a comment - The refactoring of ZogyPsfMatchTask to inherit from an ABC (comment above) will be implemented in DM-11654 .
            Hide
            Permalink
            reiss David Reiss added a comment -

            Fixed crashes in cases where dimensions of template PSF != dimensions of science img. PSF. But resizing the PSF of one or the other image often leads to the PSFs not having the same center – in this case, the cross-convolved (PSF matched) images will be offset and the subtraction will be bad. Created a new ticket (DM-11656) to address this problem.

            Show
            reiss David Reiss added a comment - Fixed crashes in cases where dimensions of template PSF != dimensions of science img. PSF. But resizing the PSF of one or the other image often leads to the PSFs not having the same center – in this case, the cross-convolved (PSF matched) images will be offset and the subtraction will be bad. Created a new ticket ( DM-11656 ) to address this problem.
            Hide
            Permalink
            reiss David Reiss added a comment - - edited

            Finally, successful Jenkins build: https://ci.lsst.codes/job/stack-os-matrix/26438/

            Show
            reiss David Reiss added a comment - - edited Finally, successful Jenkins build: https://ci.lsst.codes/job/stack-os-matrix/26438/
            Hide
            Permalink
            reiss David Reiss added a comment -

            Thanks very much for the review, Yusra AlSayyad.

            Show
            reiss David Reiss added a comment - Thanks very much for the review, Yusra AlSayyad .

              People

              • Assignee:
                reiss David Reiss
                Reporter:
                reiss David Reiss
                Reviewers:
                Yusra AlSayyad
                Watchers:
                David Reiss, Yusra AlSayyad
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel