Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10808

Add defect on ccd=43

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_subaru
    • Labels:
      None
    • Team:
      Data Release Production

      Description

      Furusawa-san writes:

      ccd=43 has also been affected by the glowing corner since 2016-04-01 UT, and better to be treated.
      Is it possible for us the include the mask for ccd=43 as well?
      A possible suggestion is as follows:

      Since 2016.4.1:

      #CCD x0 y0 width height
      43 0 0 512 200
      43 0 0 70 4176

        Attachments

          Issue Links

            Activity

            Hide
            price Paul Price added a comment -

            Nate Lust, would you please look over this simple change?

            price@pap-laptop:~/LSST/obs_subaru/hsc/defects (tickets/DM-10808=) $ git sub
            commit f84872199fd08d39c64db96eceea075536b04635
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Mon Jun 5 09:37:52 2017 -0400
             
                hsc: add defects on ccd=43
                
                Supplied by Hisanori Furusawa.
             
             hsc/defects/2016-04-01/defects.dat | 45 ++++++++++++++++++++++++++++++++++++++
             hsc/defects/2016-11-22/defects.dat |  3 +++
             hsc/defects/2016-12-23/defects.dat |  3 +++
             3 files changed, 51 insertions(+)
             
            commit a3fd6d003e7a16f13649ed2906b2c576795f8c88
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Mon Jun 5 09:38:56 2017 -0400
             
                remove unnecessary gitignore files
             
             hsc/defects/2013-01-31/.gitignore | 1 -
             hsc/defects/2014-04-03/.gitignore | 1 -
             hsc/defects/2014-06-01/.gitignore | 1 -
             hsc/defects/2014-09-01/.gitignore | 1 -
             4 files changed, 4 deletions(-)
            

            Show
            price Paul Price added a comment - Nate Lust , would you please look over this simple change? price@pap-laptop:~/LSST/obs_subaru/hsc/defects (tickets/DM-10808=) $ git sub commit f84872199fd08d39c64db96eceea075536b04635 Author: Paul Price <price@astro.princeton.edu> Date: Mon Jun 5 09:37:52 2017 -0400   hsc: add defects on ccd=43 Supplied by Hisanori Furusawa.   hsc/defects/2016-04-01/defects.dat | 45 ++++++++++++++++++++++++++++++++++++++ hsc/defects/2016-11-22/defects.dat | 3 +++ hsc/defects/2016-12-23/defects.dat | 3 +++ 3 files changed, 51 insertions(+)   commit a3fd6d003e7a16f13649ed2906b2c576795f8c88 Author: Paul Price <price@astro.princeton.edu> Date: Mon Jun 5 09:38:56 2017 -0400   remove unnecessary gitignore files   hsc/defects/2013-01-31/.gitignore | 1 - hsc/defects/2014-04-03/.gitignore | 1 - hsc/defects/2014-06-01/.gitignore | 1 - hsc/defects/2014-09-01/.gitignore | 1 - 4 files changed, 4 deletions(-)
            Hide
            nlust Nate Lust added a comment -

            Split off the new file to a new commit with a reason for adding it. If the tests say the changes don't break anything feel free to merge. The changes look benign

            Show
            nlust Nate Lust added a comment - Split off the new file to a new commit with a reason for adding it. If the tests say the changes don't break anything feel free to merge. The changes look benign
            Hide
            price Paul Price added a comment -

            Split the first commit. Jenkins is running now (not going all the way through ci_hsc, since we don't expect it will make a difference — we only care that obs_subaru builds).

            price@pap-laptop:~/LSST/obs_subaru (tickets/DM-10808=) $ git sub
            commit 6f8a7419be1a0f7a41c60fe539e3aae1466650c5
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Mon Jun 5 10:41:01 2017 -0400
             
                hsc: add defects sequence point
                
                We've identified new defects starting in 2016-04-01.
                This is a copy of the 2014-09-01 defects. We'll add
                the new defects next.
             
             hsc/defects/2016-04-01/defects.dat | 42 ++++++++++++++++++++++++++++++++++++++
             1 file changed, 42 insertions(+)
             
            commit ba69e3c32375de76d793c86a81687a2b93d5522f
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Mon Jun 5 10:42:25 2017 -0400
             
                hsc: add defects on ccd=43
                
                Supplied by Hisanori Furusawa.
             
             hsc/defects/2016-04-01/defects.dat | 3 +++
             hsc/defects/2016-11-22/defects.dat | 3 +++
             hsc/defects/2016-12-23/defects.dat | 3 +++
             3 files changed, 9 insertions(+)
             
            commit f950af1d1b90fdf3de2910ec193b6dba29203ac5
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Mon Jun 5 09:38:56 2017 -0400
             
                remove unnecessary gitignore files
             
             hsc/defects/2013-01-31/.gitignore | 1 -
             hsc/defects/2014-04-03/.gitignore | 1 -
             hsc/defects/2014-06-01/.gitignore | 1 -
             hsc/defects/2014-09-01/.gitignore | 1 -
             4 files changed, 4 deletions(-)
            

            Show
            price Paul Price added a comment - Split the first commit. Jenkins is running now (not going all the way through ci_hsc, since we don't expect it will make a difference — we only care that obs_subaru builds). price@pap-laptop:~/LSST/obs_subaru (tickets/DM-10808=) $ git sub commit 6f8a7419be1a0f7a41c60fe539e3aae1466650c5 Author: Paul Price <price@astro.princeton.edu> Date: Mon Jun 5 10:41:01 2017 -0400   hsc: add defects sequence point We've identified new defects starting in 2016-04-01. This is a copy of the 2014-09-01 defects. We'll add the new defects next.   hsc/defects/2016-04-01/defects.dat | 42 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+)   commit ba69e3c32375de76d793c86a81687a2b93d5522f Author: Paul Price <price@astro.princeton.edu> Date: Mon Jun 5 10:42:25 2017 -0400   hsc: add defects on ccd=43 Supplied by Hisanori Furusawa.   hsc/defects/2016-04-01/defects.dat | 3 +++ hsc/defects/2016-11-22/defects.dat | 3 +++ hsc/defects/2016-12-23/defects.dat | 3 +++ 3 files changed, 9 insertions(+)   commit f950af1d1b90fdf3de2910ec193b6dba29203ac5 Author: Paul Price <price@astro.princeton.edu> Date: Mon Jun 5 09:38:56 2017 -0400   remove unnecessary gitignore files   hsc/defects/2013-01-31/.gitignore | 1 - hsc/defects/2014-04-03/.gitignore | 1 - hsc/defects/2014-06-01/.gitignore | 1 - hsc/defects/2014-09-01/.gitignore | 1 - 4 files changed, 4 deletions(-)
            Hide
            price Paul Price added a comment -
            Show
            price Paul Price added a comment - Build of obs_subaru on Jenkins succeeded.
            Hide
            price Paul Price added a comment -

            Merged to master.

            Thanks Nate!

            Show
            price Paul Price added a comment - Merged to master. Thanks Nate!

              People

              • Assignee:
                price Paul Price
                Reporter:
                price Paul Price
                Reviewers:
                Nate Lust
                Watchers:
                Nate Lust, Paul Price
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: