Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-1090

Replace std::string const& fmt with char const* fmt in Log::log() and Log::vlog()

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: log
    • Labels:
      None
    • Team:
      Architecture

      Description

      For standards compliance for va_start. May require changes to places that these are called.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          ktl Kian-Tat Lim added a comment -

          Since the log package hasn't been officially approved yet, no RFC is necessary, and the only places that might be affected are Jacek's branch of Qserv incorporating log.

          Show
          ktl Kian-Tat Lim added a comment - Since the log package hasn't been officially approved yet, no RFC is necessary, and the only places that might be affected are Jacek's branch of Qserv incorporating log .
          Hide
          Permalink
          ktl Kian-Tat Lim added a comment -

          Since this only affects Qserv, and apparently only in one place, I'm giving this to Daniel.

          qserv $ git diff --stat master
          		 
           core/modules/xrdsvc/SsiService.cc | 2 +-
          		 
           1 file changed, 1 insertion(+), 1 deletion(-)
          		 
          log $ git diff --stat master
          		 
           include/lsst/log/Log.h | 6 +++---
          		 
           src/Log.cc             | 8 ++++----
          		 
           2 files changed, 7 insertions(+), 7 deletions(-)

          Show
          ktl Kian-Tat Lim added a comment - Since this only affects Qserv, and apparently only in one place, I'm giving this to Daniel. qserv $ git diff --stat master core/modules/xrdsvc/SsiService.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) log $ git diff --stat master include/lsst/log/Log.h | 6 +++--- src/Log.cc | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-)
          Hide
          Permalink
          danielw Daniel Wang [X] (Inactive) added a comment -

          Looks fine. Sorry I forgot about this one.

          Show
          danielw Daniel Wang [X] (Inactive) added a comment - Looks fine. Sorry I forgot about this one.

            People

            Assignee:
            ktl Kian-Tat Lim
            Reporter:
            ktl Kian-Tat Lim
            Reviewers:
            Daniel Wang [X] (Inactive)
            Watchers:
            Daniel Wang [X] (Inactive), Kian-Tat Lim
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: