Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10944

Decide (and maybe move) where darkTime and other header keys are scraped

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Invalid
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_base, obs_ctio0m9
    • Labels:
      None

      Description

      In obs_ctio0m9 in setArgDict the darkTime is set as follows.

          def setArgDict(self, md, argDict):
              """Fill an argument dict with arguments for makeVisitInfo and pop associated metadata
              """
              super(Ctio0m9MakeRawVisitInfo, self).setArgDict(md, argDict)
              argDict["darkTime"] = md.get("DARKTIME")
      

      it is not clear whether this would be better put in obs_base. If it should be, then the change would be to, presumably inside a try block, put

      argDict["darkTime"] = self.popFloat(md, "DARKTIME")
      

      and if so, maybe try a bunch of other likely/useful keys as well.

      If it decided that this is not appropriate, and that each obs_package should do this itself then this ticket should be marked as "Won't fix/invalid".

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            This ticket is now irrelevant. The metadata translation system was completely rewritten.

            Show
            tjenness Tim Jenness added a comment - This ticket is now irrelevant. The metadata translation system was completely rewritten.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              mfisherlevine Merlin Fisher-Levine
              Watchers:
              John Swinbank, Merlin Fisher-Levine, Robert Lupton, Simon Krughoff, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.