Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10957

Add measurement algorithm for point sources on fluff

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_base
    • Labels:
      None
    • Team:
      External

      Description

      Ultra-faint dwarf galaxies are usually found from photometry of their bright member stars. However, these stars can be superimposed on the faint, unresolved light of the galaxy, which biases the measurement. We need to measure the PSF flux with a local background subtracted.

      I originally started writing this as a background-subtracted PSF flux measurement algorithm, until I realised that simply measuring the background is all that's required (and dealing with inheritance in the measurement algorithms is annoying), and it can be subtracted from other measurements as well as the PSF flux.

        Attachments

        1. image.png
          image.png
          303 kB
        2. localBackground_hist.png
          localBackground_hist.png
          7 kB
        3. localBackground_image.png
          localBackground_image.png
          28 kB
        4. localBackgroundSigma_hist.png
          localBackgroundSigma_hist.png
          9 kB

          Activity

          Hide
          ctslater Colin Slater added a comment -

          Few small clarifications on the PR, overall looks great. I'll be interested to see how it performs on faint-fuzzies. Note that you have one fixup that can be squashed.

          This is really an excellent example of how to implement a measurement plugin, since it's conceptually pretty simple but gets into some gory (but important) details. A nice hack day project might be to take this and annotate what's going on block by block for the pipelines documentation, if we don't have such an example already. It would be very educational! I'll see who's interested at all-hands.

          Show
          ctslater Colin Slater added a comment - Few small clarifications on the PR, overall looks great. I'll be interested to see how it performs on faint-fuzzies. Note that you have one fixup that can be squashed. This is really an excellent example of how to implement a measurement plugin, since it's conceptually pretty simple but gets into some gory (but important) details. A nice hack day project might be to take this and annotate what's going on block by block for the pipelines documentation, if we don't have such an example already. It would be very educational! I'll see who's interested at all-hands.
          Hide
          price Paul Price added a comment -

          Thanks Colin.

          Made all the requested changes and rebased against master (squashing the fixups). I'm gonna run Jenkins one last time (because I've now pulled in the SkyWcs changes) just to be sure.

          Show
          price Paul Price added a comment - Thanks Colin. Made all the requested changes and rebased against master (squashing the fixups). I'm gonna run Jenkins one last time (because I've now pulled in the SkyWcs changes) just to be sure.
          Hide
          price Paul Price added a comment -

          BTW, the poster child of measurement plugin examples is supposed to be meas_extensions_simpleShape.

          Show
          price Paul Price added a comment - BTW, the poster child of measurement plugin examples is supposed to be meas_extensions_simpleShape .
          Hide
          price Paul Price added a comment - - edited

          Jenkins passed on all systems except for OSX, where it succumbed to an existing error in jointcal (DM-13603).

          Show
          price Paul Price added a comment - - edited Jenkins passed on all systems except for OSX, where it succumbed to an existing error in jointcal ( DM-13603 ).
          Hide
          price Paul Price added a comment -

          Merged to master.

          Show
          price Paul Price added a comment - Merged to master.

            People

            Assignee:
            price Paul Price
            Reporter:
            price Paul Price
            Reviewers:
            Colin Slater
            Watchers:
            Colin Slater, Jeffrey Carlin, Paul Price
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.