Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10973

Make SkyWcs transform to IcrsCoord instead of SpherePoint

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Templates:
    • Story Points:
      5
    • Epic Link:
    • Sprint:
      Alert Production S17 - 6
    • Team:
      Alert Production

      Description

      At present SkyWcs is a subclass of Transform<Point2Endpoint, SpherePointEndpoint> and this means that pixelToSky transforms to SpherePoint. However SkyWcs is always normalized to ICRS and so pixelToSky should probably produce IcrsCoord.

      The simplest way to change this is to change SpherePointEndpoint to IcrsCoordEndpoint. One obvious alternative is to keep both and change the endpoint class SkyWcs uses. However, we have no identified need for Transform to transform to SpherePoint (nor IcrsCoord except as a base class for SkyWcs). Furthermore if we have N Endpoint classes then we instantiate N^2 Transform classes. So I propose to simply rename for now.

        Attachments

          Container Issues

            Issue Links

              Activity

                People

                • Assignee:
                  rowen Russell Owen
                  Reporter:
                  rowen Russell Owen
                  Reviewers:
                  Pim Schellart [X] (Inactive)
                  Watchers:
                  John Parejko, Krzysztof Findeisen, Pim Schellart [X] (Inactive), Russell Owen
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Summary Panel