Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-10998

buildbot-scripts cleanups

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Continuous Integration
    • Labels:
      None

      Description

      There are a couple of small issues with lsst-sqre/buildbot-scripts that could be improved, including:

      • Inconsistent use of true/false, 0/1, and "yes"/"no" for boolean values.
      • printing of variables that are no longer in use (DEMO_ROOT & DEMO_TGZ).
      • inconsistent use of posix and bash style conditional expressions

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          jhoblitt Joshua Hoblitt added a comment -

          Could one of (Tim Jenness, Adam Thornton) take a look at this. I also want to change the source to use a 2 space indent on this ticket but am not planning to put it up for review due as it would be just noise. I still need to stand up a full test env to run this through before it is ready for merge.

          Show
          jhoblitt Joshua Hoblitt added a comment - Could one of ( Tim Jenness , Adam Thornton ) take a look at this. I also want to change the source to use a 2 space indent on this ticket but am not planning to put it up for review due as it would be just noise. I still need to stand up a full test env to run this through before it is ready for merge.
          Hide
          Permalink
          jhoblitt Joshua Hoblitt added a comment -

          I've added a whitespace/ident consistently commit post review on GH. This was manually tested as being able to build cfitsio on el6/el7 under py2/py3.

          Show
          jhoblitt Joshua Hoblitt added a comment - I've added a whitespace/ident consistently commit post review on GH. This was manually tested as being able to build cfitsio on el6/el7 under py2/py3.

            People

            Assignee:
            jhoblitt Joshua Hoblitt
            Reporter:
            jhoblitt Joshua Hoblitt
            Reviewers:
            Adam Thornton, Tim Jenness
            Watchers:
            Adam Thornton, Joshua Hoblitt, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.