Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-11051

Change logger level for wcs warning

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None

      Description

      DM-10559 introduced a warning when makeWcs() fails to construct a wcs, but the level was too high. It should be reduced DEBUG level warning.

        Attachments

          Issue Links

            Activity

            Hide
            fred3m Fred Moolekamp added a comment -

            You successfully changed the word "WARN" to "DEBUG". Very nice. We discussed this offline, but just to keep a record: as long as a warning is displayed elsewhere when a WCS fails and this passes tests on Jenkins, this ticket is good to merge.

            I do think that at some point this issue should be revisited, in that the reason these log messages are SPAM is because makeWcs is being called even when it is known that there is no WCS information in the image. A better solution in the future might be to only call makeWcs (and other similar methods) when a WCS is both needed and known to be present.

            Show
            fred3m Fred Moolekamp added a comment - You successfully changed the word "WARN" to "DEBUG". Very nice. We discussed this offline, but just to keep a record: as long as a warning is displayed elsewhere when a WCS fails and this passes tests on Jenkins, this ticket is good to merge. I do think that at some point this issue should be revisited, in that the reason these log messages are SPAM is because makeWcs is being called even when it is known that there is no WCS information in the image. A better solution in the future might be to only call makeWcs (and other similar methods) when a WCS is both needed and known to be present.
            Hide
            mfisherlevine Merlin Fisher-Levine added a comment -

            I totally agree. You should head over to DM-9905 and tell Robert and Russell your thoughts on the matter; it's a good point but out of scope for this ticket

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - I totally agree. You should head over to DM-9905 and tell Robert and Russell your thoughts on the matter; it's a good point but out of scope for this ticket
            Hide
            mfisherlevine Merlin Fisher-Levine added a comment -

            Merged.

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - Merged.

              People

              • Assignee:
                mfisherlevine Merlin Fisher-Levine
                Reporter:
                mfisherlevine Merlin Fisher-Levine
                Reviewers:
                Fred Moolekamp
                Watchers:
                Fred Moolekamp, Merlin Fisher-Levine, Robert Lupton
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel