Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-11095

Add reference catalog flux support to photometry fitter

    Details

      Description

      While implementing DM-9195, I realized that jointcal did not actually use a photometric reference catalog. This is a retro-active ticket for the work that was done to implement the reference flux support, and all the necessary pieces of the photometry fitter to use it.

        Attachments

          Issue Links

            Activity

            Hide
            Parejkoj John Parejko added a comment -

            Going to move my work so far from DM-9195 onto this branch, since most of that work was actually for this purpose.

            Show
            Parejkoj John Parejko added a comment - Going to move my work so far from DM-9195 onto this branch, since most of that work was actually for this purpose.
            Hide
            Parejkoj John Parejko added a comment -

            Thanks for agreeing to review this, and sorry it took so long to finally get it ready to go.

            The changes include the beginning of work on DM-9195, but the constrainedPhotometryModel doesn't actually do anything right now, though I believe it's harmless to leave in as I will tackle DM-9195 immediately after this.

            I squashed the commits quite a bit, but it's now at the point where it's a lot more work to squash them in a semi-reasonable fashion. Please let me know if you'd rather I did more commit flattening or not. It includes quite a bit of refactoring (both variable renames and base-class creation/reshuflling).

            Jenkins run here: https://ci.lsst.codes/job/stack-os-matrix/25544/

            Show
            Parejkoj John Parejko added a comment - Thanks for agreeing to review this, and sorry it took so long to finally get it ready to go. The changes include the beginning of work on DM-9195 , but the constrainedPhotometryModel doesn't actually do anything right now, though I believe it's harmless to leave in as I will tackle DM-9195 immediately after this. I squashed the commits quite a bit, but it's now at the point where it's a lot more work to squash them in a semi-reasonable fashion. Please let me know if you'd rather I did more commit flattening or not. It includes quite a bit of refactoring (both variable renames and base-class creation/reshuflling). Jenkins run here: https://ci.lsst.codes/job/stack-os-matrix/25544/
            Hide
            Parejkoj John Parejko added a comment -
            Show
            Parejkoj John Parejko added a comment - Post-review Jenkins run: https://ci.lsst.codes/job/stack-os-matrix/25678/
            Hide
            Parejkoj John Parejko added a comment -

            Thanks for all the review comments. Jenkins passed.

            Merged and done.

            Show
            Parejkoj John Parejko added a comment - Thanks for all the review comments. Jenkins passed. Merged and done.

              People

              • Assignee:
                Parejkoj John Parejko
                Reporter:
                Parejkoj John Parejko
                Reviewers:
                Jim Bosch
                Watchers:
                Dominique Boutigny, Jim Bosch, John Parejko, Pierre Astier, Simon Krughoff
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel