Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: obs_base
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:DRP F17-1
-
Team:Data Release Production
Description
Please create VisitInfo whenever we read an Exposure from disk if suitable metadata is available.
Currently this is done in the std_raw method, but it's also needed when e.g. reading master dark calibration frames from DecoratedImages.
Attachments
Issue Links
Activity
One itty-bitty comment on the GitHub PR (which eventually showed up in Jira).
I don't think this needs to be RFC-ed. It's low-level and will be used (unknowingly) by other cameras, but the API change uses default values, so I don't think it should cause any trouble and can only benefit everyone. Nevertheless, please be sure to run ci_hsc with this change just in case...
Paul Price
added a comment - One itty-bitty comment on the GitHub PR (which eventually showed up in Jira).
I don't think this needs to be RFC-ed. It's low-level and will be used (unknowingly) by other cameras, but the API change uses default values, so I don't think it should cause any trouble and can only benefit everyone. Nevertheless, please be sure to run ci_hsc with this change just in case... Jenkinsed, merged, pushed.
Hmmm, this change might have passed Jenkins and ci_hsc, but all my expTimes are coming back as NaNs, and most of the metadata is absent now.
I'm working on fixing this.
As of now, I see:
- Some work merged to obs_base on this PR: https://github.com/lsst/obs_base/pull/50
- A tickets/DM-1163 branch on obs_base which is "1 commit ahead of master"
- A tickets/DM-1163 branch on obs_comCam which is "8 commits ahead of master"
I think some of this work is actually part of DM-11223, but it's not at all obvious what's really going on. Please can you clarify which work is actually included on this ticket?
The pull-request exists but Jira isn't seeing it. I probably did something wrong, so be careful!