Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-11163

Always create VisitInfo from metadata when available

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_base
    • Labels:
      None

      Description

      Please create VisitInfo whenever we read an Exposure from disk if suitable metadata is available.

      Currently this is done in the std_raw method, but it's also needed when e.g. reading master dark calibration frames from DecoratedImages.

        Attachments

          Issue Links

            Activity

            Hide
            rhl Robert Lupton added a comment -

            The pull-request exists but Jira isn't seeing it. I probably did something wrong, so be careful!

            Show
            rhl Robert Lupton added a comment - The pull-request exists but Jira isn't seeing it. I probably did something wrong, so be careful!
            Hide
            price Paul Price added a comment -

            One itty-bitty comment on the GitHub PR (which eventually showed up in Jira).

            I don't think this needs to be RFC-ed. It's low-level and will be used (unknowingly) by other cameras, but the API change uses default values, so I don't think it should cause any trouble and can only benefit everyone. Nevertheless, please be sure to run ci_hsc with this change just in case...

            Show
            price Paul Price added a comment - One itty-bitty comment on the GitHub PR (which eventually showed up in Jira). I don't think this needs to be RFC-ed. It's low-level and will be used (unknowingly) by other cameras, but the API change uses default values, so I don't think it should cause any trouble and can only benefit everyone. Nevertheless, please be sure to run ci_hsc with this change just in case...
            Hide
            rhl Robert Lupton added a comment -

            Jenkinsed, merged, pushed.

            Show
            rhl Robert Lupton added a comment - Jenkinsed, merged, pushed.
            Hide
            mfisherlevine Merlin Fisher-Levine added a comment -

            Hmmm, this change might have passed Jenkins and ci_hsc, but all my expTimes are coming back as NaNs, and most of the metadata is absent now.

            I'm working on fixing this.

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - Hmmm, this change might have passed Jenkins and ci_hsc, but all my expTimes are coming back as NaNs, and most of the metadata is absent now. I'm working on fixing this.
            Hide
            swinbank John Swinbank added a comment -

            As of now, I see:

            I think some of this work is actually part of DM-11223, but it's not at all obvious what's really going on. Please can you clarify which work is actually included on this ticket?

            Show
            swinbank John Swinbank added a comment - As of now, I see: Some work merged to obs_base on this PR: https://github.com/lsst/obs_base/pull/50 A tickets/ DM-1163 branch on obs_base which is "1 commit ahead of master" A tickets/ DM-1163 branch on obs_comCam which is "8 commits ahead of master" I think some of this work is actually part of DM-11223 , but it's not at all obvious what's really going on. Please can you clarify which work is actually included on this ticket?

              People

              • Assignee:
                rhl Robert Lupton
                Reporter:
                rhl Robert Lupton
                Reviewers:
                Paul Price
                Watchers:
                John Swinbank, Merlin Fisher-Levine, Paul Price, Robert Lupton
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel