# Fix breaking changes introduced in DM-11163

XMLWordPrintable

## Details

• Type: Story
• Status: Won't Fix
• Resolution: Done
• Fix Version/s: None
• Component/s: None
• Labels:
None
• Story Points:
1
• Sprint:
DRP F17-2
• Team:
Data Release Production

## Description

DM-11163 allegedly passed Jenkins & ci_hsc, but seems to break everything for me, with all my visit infos that used to be correctly populated coming back with Nans for the expTimes and DateTime()s for the dates when running constructBias.py

Working on fixing this now...

## Activity

Hide
Robert Lupton added a comment -

I think that Merlin failed to update pipe_drivers along with obs_base; I should have linked the tickets. Can you confirm that there are no breaking changes?

What is true is that people who, like LSST, write amplifier images in separate HDUs (and don't specify INHERIT) will get a lot of warnings. I have pushed a change to obs_base that allows us to avoid this, and a patch to obs_comCam that uses it (relative to DM-9872)

Please confirm that this analysis is correct, and that the fixes work and don't break other things, as part of this review.

Show
Robert Lupton added a comment - I think that Merlin failed to update pipe_drivers along with obs_base; I should have linked the tickets. Can you confirm that there are no breaking changes? What is true is that people who, like LSST, write amplifier images in separate HDUs (and don't specify INHERIT ) will get a lot of warnings. I have pushed a change to obs_base that allows us to avoid this, and a patch to obs_comCam that uses it (relative to DM-9872 ) Please confirm that this analysis is correct, and that the fixes work and don't break other things, as part of this review.
Hide
Merlin Fisher-Levine added a comment -

It should be noted for future generations that the changes referred to above have been pushed to the ticket that originally introduced the problem, i.e. DM-11163.

Show
Merlin Fisher-Levine added a comment - It should be noted for future generations that the changes referred to above have been pushed to the ticket that originally introduced the problem, i.e. DM-11163 .
Hide
John Swinbank added a comment -

I can't figure out from the text above where the work corresponding to this ticket lives. Before marking this as reviewed (or closing it altogether), please make sure it's clear what's actually done.

Show
John Swinbank added a comment - I can't figure out from the text above where the work corresponding to this ticket lives. Before marking this as reviewed (or closing it altogether), please make sure it's clear what's actually done.
Hide
John Swinbank added a comment - - edited

Robert Lupton, I'm told this has been fixed on DM-11163. Do you agree?

Show
John Swinbank added a comment - - edited Robert Lupton , I'm told this has been fixed on DM-11163 . Do you agree?

## People

• Assignee:
Merlin Fisher-Levine
Reporter:
Merlin Fisher-Levine
Reviewers:
Merlin Fisher-Levine
Watchers:
John Swinbank, Merlin Fisher-Levine, Paul Price, Robert Lupton