Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-11235

Support INHERIT directly in Fits::readMetadata

    XMLWordPrintable

    Details

    • Type: Story
    • Status: To Do
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None
    • Team:
      Data Release Production

      Description

      The handling for the FITS keyword INHERIT is in the free function readMetadata in fits.cc rather than in the closer-to-the-metal member function Fits::readMetadata.

      I'm pretty sure that it's safe to move it to Fits (simplifying the reading of e.g. DecoratedImages – see the linked ticket), and this ticket requests that that be done.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-11236 Image constructors do not obey INHERIT

          • Done
          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            DecoratedImage has been deprecated for at least 6 years (see DM-3190) and obs_lsst does not use a DecoratedImage.

            Show
            tjenness Tim Jenness added a comment - DecoratedImage has been deprecated for at least 6 years (see DM-3190 ) and obs_lsst does not use a DecoratedImage.
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            I'd be even more interested in dropping one of the two readMetadata's entirely, but if this is the main way the differ, maybe it's a good step towards that.

            I did notice some code that handled in INHERIT in one of raw formatter classes recently, so there would probably be some fallout from this change - just not enough to make it a bad idea.  Still, not something I see us making a high priority soon.

            Show
            jbosch Jim Bosch added a comment - I'd be even more interested in dropping one of the two readMetadata's entirely, but if this is the main way the differ, maybe it's a good step towards that. I did notice some code that handled in INHERIT in one of raw formatter classes recently, so there would probably be some fallout from this change - just not enough to make it a bad idea.  Still, not something I see us making a high priority soon.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              rhl Robert Lupton
              Watchers:
              Jim Bosch, Robert Lupton, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:

                  Jenkins

                  No builds found.