Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-11245

Improve Lander's logic for displaying 'draft' notice and docushare links

    Details

      Description

      Make the following changes to Lander:

      • Always include the "View on DocuShare" button for controlled document types (LDM, LSE, LPM, and so on). Implement as a whitelist, and use the ls.st short link form. This makes the --docushare-url command line optional have a good automatic default.
      • Do not show the DRAFT notice for builds on master and docushare-vN branch/tag names.

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            Current policy is that master is never a draft (at least for change-controlled documents). DocuShare allows drafts so you can't assume that a docushare-vN tag refers to a non-draft document. DocuShare itself does not ever know released vs draft status; all it knows is the current default ("preferred") version. A docushare tag draft status therefore depends on the document draft status, which is derived in latex from the documentclass line.

            Show
            tjenness Tim Jenness added a comment - Current policy is that master is never a draft (at least for change-controlled documents). DocuShare allows drafts so you can't assume that a docushare-vN tag refers to a non-draft document. DocuShare itself does not ever know released vs draft status; all it knows is the current default ("preferred") version. A docushare tag draft status therefore depends on the document draft status, which is derived in latex from the documentclass line.
            Hide
            jsick Jonathan Sick added a comment -

            This implements improved handling of DocuShare links and draft status as described in the Lander PR: https://github.com/lsst-sqre/lander/pull/3

            There is also a supporting metasrc PR to support the lsstdraft option detection: https://github.com/lsst-sqre/metasrc/pull/4

            Show
            jsick Jonathan Sick added a comment - This implements improved handling of DocuShare links and draft status as described in the Lander PR: https://github.com/lsst-sqre/lander/pull/3 There is also a supporting metasrc PR to support the lsstdraft option detection: https://github.com/lsst-sqre/metasrc/pull/4
            Hide
            tjenness Tim Jenness added a comment -

            Looks fine. More complicated than current policy requires but will be useful if the policy evolves in the near future.

            Show
            tjenness Tim Jenness added a comment - Looks fine. More complicated than current policy requires but will be useful if the policy evolves in the near future.
            Hide
            jsick Jonathan Sick added a comment -

            Distributed in lander==0.1.5 and metasrc==0.1.3

            Show
            jsick Jonathan Sick added a comment - Distributed in lander==0.1.5 and metasrc==0.1.3

              People

              • Assignee:
                jsick Jonathan Sick
                Reporter:
                jsick Jonathan Sick
                Reviewers:
                Tim Jenness
                Watchers:
                Jonathan Sick, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel