Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-1125

avoid usage of measurement framework in star selectors

    XMLWordPrintable

    Details

      Description

      At least one of the star selectors uses the old measurement framework system to measure the moments of a cloud of points. With the new versions of all the measurement plugins, it should be much easier (and cleaner) to just call the SdssShape algorithm directly, instead of dealing with the complexity of applying the measurement framework to something that isn't really an image.

        Attachments

          Activity

          Hide
          pgee Perry Gee added a comment -

          This change is slightly different from what was originally proposed in this ticket. It was decided that it was useful to have the Selector continue to use the measurement framework, but that it should always use the new framework for its histogramming.

          Show
          pgee Perry Gee added a comment - This change is slightly different from what was originally proposed in this ticket. It was decided that it was useful to have the Selector continue to use the measurement framework, but that it should always use the new framework for its histogramming.
          Hide
          pgee Perry Gee added a comment -

          Simon: this ticket has been sitting in review for a long time. Could you possible review it and mark it done before you close today's Sprint.

          It is now a very simple change, as I talked Jim into changing the scope of the ticket so that it only removes the use of the meas_algorithms framework. So there is no code here which was not in previous versions.

          Show
          pgee Perry Gee added a comment - Simon: this ticket has been sitting in review for a long time. Could you possible review it and mark it done before you close today's Sprint. It is now a very simple change, as I talked Jim into changing the scope of the ticket so that it only removes the use of the meas_algorithms framework. So there is no code here which was not in previous versions.
          Hide
          krughoff Simon Krughoff added a comment -

          I just finished this review. The major thing is that I don't understand how passing display as a positional argument to a function defined with keyword arguments works when display is the second keyword argument. I also commented on how to better break up commits.

          Pull request with comments is at:
          https://github.com/LSST/meas_algorithms/pull/1

          Show
          krughoff Simon Krughoff added a comment - I just finished this review. The major thing is that I don't understand how passing display as a positional argument to a function defined with keyword arguments works when display is the second keyword argument. I also commented on how to better break up commits. Pull request with comments is at: https://github.com/LSST/meas_algorithms/pull/1
          Hide
          pgee Perry Gee added a comment -

          Thanks Simon. I don't recall changing anything that would affect this, but perhaps I did in some previous checkin. I will look at it later. Since the Sprint is now over, I am not longer feeling in a hurry.

          Can you tell me how I should response to the github comments individually?

          Show
          pgee Perry Gee added a comment - Thanks Simon. I don't recall changing anything that would affect this, but perhaps I did in some previous checkin. I will look at it later. Since the Sprint is now over, I am not longer feeling in a hurry. Can you tell me how I should response to the github comments individually?
          Hide
          krughoff Simon Krughoff added a comment -

          You can just bring up the pull request. If you go to the commit view, you should be able to add responses to the comment. Let me know if that doesn't do it for you.

          Show
          krughoff Simon Krughoff added a comment - You can just bring up the pull request. If you go to the commit view, you should be able to add responses to the comment. Let me know if that doesn't do it for you.

            People

            Assignee:
            pgee Perry Gee
            Reporter:
            jbosch Jim Bosch
            Reviewers:
            Simon Krughoff
            Watchers:
            Jim Bosch, Lauren MacArthur, Perry Gee, Simon Krughoff
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.