Fix Version/s: None
Sprint:Science Pipelines DM-W15-3, Science Pipelines DM-W15-4
Team:Data Release Production
At least one of the star selectors uses the old measurement framework system to measure the moments of a cloud of points. With the new versions of all the measurement plugins, it should be much easier (and cleaner) to just call the SdssShape algorithm directly, instead of dealing with the complexity of applying the measurement framework to something that isn't really an image.
Simon: this ticket has been sitting in review for a long time. Could you possible review it and mark it done before you close today's Sprint.
It is now a very simple change, as I talked Jim into changing the scope of the ticket so that it only removes the use of the meas_algorithms framework. So there is no code here which was not in previous versions.
I just finished this review. The major thing is that I don't understand how passing display as a positional argument to a function defined with keyword arguments works when display is the second keyword argument. I also commented on how to better break up commits.
Pull request with comments is at:
Thanks Simon. I don't recall changing anything that would affect this, but perhaps I did in some previous checkin. I will look at it later. Since the Sprint is now over, I am not longer feeling in a hurry.
Can you tell me how I should response to the github comments individually?
You can just bring up the pull request. If you go to the commit view, you should be able to add responses to the comment. Let me know if that doesn't do it for you.
This change is slightly different from what was originally proposed in this ticket. It was decided that it was useful to have the Selector continue to use the measurement framework, but that it should always use the new framework for its histogramming.