Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-11264

Remove explicit addition of PDU metadata to Exposure (HDU 1) metadata

    XMLWordPrintable

    Details

    • Type: Story
    • Status: To Do
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: obs_decam
    • Labels:
      None
    • Team:
      Alert Production

      Description

      Since DM-11236 was fixed (obey INHERIT) there is no need to explicitly copy PDU metadata to the Exposure metadata in the obs_decam mapper.

        Attachments

          Issue Links

            Activity

            Hide
            jbosch Jim Bosch added a comment -

            Reviewing for CCB: I think the work on this ticket is now really, "check that we are not unnecessarily copying PDU metadata for DECam raws in Gen3".  I suspect the behavior is already correct, but it's nontrivial to check so I'll leave that for the ticket.

            Show
            jbosch Jim Bosch added a comment - Reviewing for CCB: I think the work on this ticket is now really, "check that we are not unnecessarily copying PDU metadata for DECam raws in Gen3".  I suspect the behavior is already correct, but it's nontrivial to check so I'll leave that for the ticket.
            Hide
            tjenness Tim Jenness added a comment -

            It looks like we do read the primary header for DECam data as part of file ingest (it may even be read once by afw (because we don't yet know it's DECam data), and once by astropy as part of the per-detector read). I don't know if astropy supports INHERIT.

            The raw formatter does not read the primary HDU, but it tries to read every HDU in order until it finds the correct one for the requested detector. I do see that DECam data does name the HDUs so I wonder if the raw formatter could instead calculate the detector name and then ask the FITS reader for that detector name explicitly.

            Show
            tjenness Tim Jenness added a comment - It looks like we do read the primary header for DECam data as part of file ingest (it may even be read once by afw (because we don't yet know it's DECam data), and once by astropy as part of the per-detector read). I don't know if astropy supports INHERIT. The raw formatter does not read the primary HDU, but it tries to read every HDU in order until it finds the correct one for the requested detector. I do see that DECam data does name the HDUs so I wonder if the raw formatter could instead calculate the detector name and then ask the FITS reader for that detector name explicitly.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              rhl Robert Lupton
              Watchers:
              Jim Bosch, Robert Lupton, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:

                  Jenkins

                  No builds found.