Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-1128

Span-based grow operations for Footprint

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw

      Description

      The current grow operation for Footprints is very inefficient for isotropic grows. A better algorithm can be found in the attached paper.

        Attachments

        1. 27-06-20.pdf
          230 kB
        2. Footprint.cpp
          7 kB
        3. Footprint.hpp
          9 kB
        4. RLE Operations.pdf
          1.27 MB

          Issue Links

            Activity

            Hide
            swinbank John Swinbank added a comment -

            Done; that's DM-1545.

            Show
            swinbank John Swinbank added a comment - Done; that's DM-1545 .
            Hide
            jbosch Jim Bosch added a comment -

            Code review is on the attached GitHub PR. There are a few minor issues I'd like to see addressed (and one more major one I'd be quite willing to defer unless you want to deal with it here), but you don't need to get any further sign-off from me before merging after you feel you've addressed them.

            Show
            jbosch Jim Bosch added a comment - Code review is on the attached GitHub PR. There are a few minor issues I'd like to see addressed (and one more major one I'd be quite willing to defer unless you want to deal with it here), but you don't need to get any further sign-off from me before merging after you feel you've addressed them.
            Hide
            swinbank John Swinbank added a comment -

            Jim – sorry to bother you with this one again, but I started playing with defining a custom class for holding structuring elements on the train home last night. I've just pushed a commit which implements that, and hence also switches over the grow up/down/left/right functionality to the same implementation as the other grows. Could you check that you are happy with this, please?

            Show
            swinbank John Swinbank added a comment - Jim – sorry to bother you with this one again, but I started playing with defining a custom class for holding structuring elements on the train home last night. I've just pushed a commit which implements that, and hence also switches over the grow up/down/left/right functionality to the same implementation as the other grows. Could you check that you are happy with this, please?
            Hide
            jbosch Jim Bosch added a comment -

            A few more minor comments on github. I do like this version better, overall.

            Show
            jbosch Jim Bosch added a comment - A few more minor comments on github. I do like this version better, overall.
            Hide
            swinbank John Swinbank added a comment -

            Thanks for being so quick with the review!

            Show
            swinbank John Swinbank added a comment - Thanks for being so quick with the review!

              People

              Assignee:
              swinbank John Swinbank
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Jim Bosch
              Watchers:
              Jim Bosch, John Swinbank, Robert Lupton
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins Builds

                  No builds found.