Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-11289

RepositoryArgs needs to check that mapperArgs is dict-like

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: butler
    • Labels:
      None

      Description

      RepositoryArgs.mapperArgs is assumed to be dict-like (e.g. if 'root' not in mapperArgs), but it can be initialised to None.

      The init function needs to guarantee that mapperArgs is dict-like. I think that we should also fix the default value (RepositoryArgs.__init__() has a default mapperArgs=None), although we could just add the test; but I think it's clearer to set the default to a valid value too.

      N.b. mapperArgs is omitted from the class docstring, which otherwise duplicates most of the __init__ docstring.

        Attachments

          Activity

          Hide
          rhl Robert Lupton added a comment -

          I have pushed a set of changes (relating to DM-11288 and DM-11289) to branch u/rhl/DM-11288

          Show
          rhl Robert Lupton added a comment - I have pushed a set of changes (relating to DM-11288 and DM-11289 ) to branch u/rhl/ DM-11288
          Hide
          npease Nate Pease added a comment -

          Kenny, can you please review this?

          Show
          npease Nate Pease added a comment - Kenny, can you please review this?
          Hide
          npease Nate Pease added a comment -

          Kenny approved the PR.

          (Kenny Lo you must set the status of the Jira issue to Review Complete separately. Normally the reviewer does this.)

          Show
          npease Nate Pease added a comment - Kenny approved the PR. ( Kenny Lo you must set the status of the Jira issue to Review Complete separately. Normally the reviewer does this.)

            People

            • Assignee:
              npease Nate Pease
              Reporter:
              rhl Robert Lupton
              Reviewers:
              Kenny Lo
              Watchers:
              Kenny Lo, Nate Pease, Robert Lupton
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel