Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-11329

Create command line task for NMF deblender

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Story Points:
      18
    • Sprint:
      DRP F17-4, DRP F17-5, DRP F17-6
    • Team:
      Data Release Production

      Description

      In order to test the deblender on a large patch of HSC data (see DM-11909), a new task MultibandDeblendTask needs to be created that takes a collection of catalogs as an input to run the new deblender. This ticket will result in the creation of the task, including a modification to MultibandDriver that will call MultibandDeblenderTask after merging the coadd catalogs, and before calling MeasureCoaddSources (as opposed to the current scheme, which calls SourceDeblendTask inside of MeasureCoaddSources.

        Attachments

          Issue Links

            Activity

            swinbank John Swinbank created issue -
            swinbank John Swinbank made changes -
            Field Original Value New Value
            Epic Link DM-10353 [ 32070 ]
            fred3m Fred Moolekamp made changes -
            Sprint DRP F17-3 [ 622 ] DRP F17-4 [ 623 ]
            fred3m Fred Moolekamp made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            fred3m Fred Moolekamp made changes -
            Link This issue relates to DM-11909 [ DM-11909 ]
            swinbank John Swinbank made changes -
            Sprint DRP F17-4 [ 623 ] DRP F17-4, DRP F17-5 [ 623, 624 ]
            swinbank John Swinbank made changes -
            Rank Ranked higher
            fred3m Fred Moolekamp made changes -
            Story Points 6 12
            fred3m Fred Moolekamp made changes -
            Description In order to test the deblender on a large patch of HSC data (see DM-11909), a new task {{MultibandDeblendTask}} needs to be created that takes a collection of catalogs as an input to run the new deblender. This ticket will result in the creation of the task, including a modification to {{MultibandDriver}} that will call {{MultibandDeblenderTask}} after merging the coadd catalogs, and before calling {{MeasureCoaddSources}} (as opposed to the current scheme, which calls {{SourceDeblendTask}} inside of {{MeasureCoaddSources}}.
            fred3m Fred Moolekamp made changes -
            Story Points 12 18
            Hide
            fred3m Fred Moolekamp added a comment -

            Hi Pim, this is the ticket we talked about the other day. The new task `MultibandDeblendTask` is basically a clone of the existing `SourceDeblendTask`, updated to use the new deblender. Let me know if you have any questions.

            The Jenkins python 2 build failed due to meas_base, but python 3 passed and (when run on tiger) all python 2 tests pass as well. Jenkins is currently building again, I'll update the ticket if the python 2 build fails again.

            This notebook shows the task working on ci_hsc.

            Thanks,
            -Fred

            Show
            fred3m Fred Moolekamp added a comment - Hi Pim, this is the ticket we talked about the other day. The new task `MultibandDeblendTask` is basically a clone of the existing `SourceDeblendTask`, updated to use the new deblender. Let me know if you have any questions. The Jenkins python 2 build failed due to meas_base, but python 3 passed and (when run on tiger) all python 2 tests pass as well. Jenkins is currently building again, I'll update the ticket if the python 2 build fails again. This notebook shows the task working on ci_hsc. Thanks, -Fred
            fred3m Fred Moolekamp made changes -
            Reviewers Pim Schellart [ pschella ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            swinbank John Swinbank made changes -
            Sprint DRP F17-4, DRP F17-5 [ 623, 624 ] DRP F17-4, DRP F17-5, DRP F17-6 [ 623, 624, 625 ]
            swinbank John Swinbank made changes -
            Rank Ranked higher
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            See PR for comments.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - See PR for comments.
            pschella Pim Schellart [X] (Inactive) made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            Hide
            fred3m Fred Moolekamp added a comment -

            merged changes to user branch

            Show
            fred3m Fred Moolekamp added a comment - merged changes to user branch
            fred3m Fred Moolekamp made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              • Assignee:
                fred3m Fred Moolekamp
                Reporter:
                swinbank John Swinbank
                Reviewers:
                Pim Schellart [X] (Inactive)
                Watchers:
                Fred Moolekamp, John Swinbank, Pim Schellart [X] (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel