Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-11397

Remove twinkles1 jointcal testdata and tests

    XMLWordPrintable

    Details

      Description

      The reference catalogs supplied with the twinkles data I have are in the a.net format, and do not contain flux errors. When we update them to the new style format, we should also add flux errors of some sort, so that they can be used with jointcal's new photometry system.

       

      Update: after much thought and discussion, we decided that the twinkles1 jointcal testdata no longer serves a useful purpose, and is holding us up from removing a.net refcats and obs_lsstSim. Instead of trying to update the included refcat (the HTM indexed version that Simon Krughoff found was not a drop in replacement), I'm going to delete the twinkles data and tests all together. We'll be getting some DC2 data built on obs_lsst soon enough, and we will have to write entirely new tests for that anyway.

        Attachments

          Issue Links

            Activity

            Hide
            Parejkoj John Parejko added a comment -

            Simon Krughoff: can you review this? It's basically all deletions in two packages (jointcal and testdata_jointcal), so should be a trivial review.

            If you have a strong reason to think we should keep this data here, please let me know.

            Show
            Parejkoj John Parejko added a comment - Simon Krughoff : can you review this? It's basically all deletions in two packages (jointcal and testdata_jointcal), so should be a trivial review. If you have a strong reason to think we should keep this data here, please let me know.
            Show
            Parejkoj John Parejko added a comment - Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29443/pipeline
            Hide
            krughoff Simon Krughoff added a comment -

            Can do.

            Show
            krughoff Simon Krughoff added a comment - Can do.
            Hide
            krughoff Simon Krughoff added a comment -

            Looks good.

            Show
            krughoff Simon Krughoff added a comment - Looks good.
            Hide
            Parejkoj John Parejko added a comment -

            Thanks for the review. I think (hope!) that this is the last thing remaining before we can remove a.net support.

            Merged and done.

            Show
            Parejkoj John Parejko added a comment - Thanks for the review. I think (hope!) that this is the last thing remaining before we can remove a.net support. Merged and done.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Simon Krughoff
              Watchers:
              John Parejko, John Swinbank, Simon Krughoff
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.