Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-11430

weekly release w_2017_30 failed

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Continuous Integration
    • Labels:
      None

      Description

      The w_2017_30 weekly release failed due to master being broken.

        Attachments

          Issue Links

            Activity

            Hide
            jhoblitt Joshua Hoblitt added a comment - - edited

            I have added the ability to update a pre-existing annotated tag to github3.py. After a bunch of fiddling around trying to unwind the requests mock[ing] wrappers, as an attempt to properly unit test a top level method that results in multiple REST calls (which none of the existing unit tests seems to do), I gave up and opened PRs upstream:

            1. https://github.com/sigmavirus24/github3.py/pull/724
            2. https://github.com/sigmavirus24/github3.py/pull/725 (based on 724, as I think that is more likely to be accepted upstream as-is)

            sqre-codekit will need a minor update to use the tag moving feature.

            Show
            jhoblitt Joshua Hoblitt added a comment - - edited I have added the ability to update a pre-existing annotated tag to github3.py . After a bunch of fiddling around trying to unwind the requests mock [ing] wrappers, as an attempt to properly unit test a top level method that results in multiple REST calls (which none of the existing unit tests seems to do), I gave up and opened PRs upstream: https://github.com/sigmavirus24/github3.py/pull/724 https://github.com/sigmavirus24/github3.py/pull/725 (based on 724, as I think that is more likely to be accepted upstream as-is) sqre-codekit will need a minor update to use the tag moving feature.
            Hide
            jhoblitt Joshua Hoblitt added a comment -
            Show
            jhoblitt Joshua Hoblitt added a comment - Pushed to pypi as https://pypi.python.org/pypi/sqre-codekit-github3.py
            Hide
            jhoblitt Joshua Hoblitt added a comment -

            I manually "tested" the new --force-tag flag github-tag-version by running it against the production repos.

            github-tag-version --org 'lsst' --team 'Data Management' --email 'sqre-admin@lists.lsst.org' --tagger 'sqreadmin' --debug "w.2017.30" "b2974" --force-tag
            

            [master] ~/github/afw $ git fetch --all --tags --prune
            Fetching origin
            remote: Counting objects: 18, done.
            remote: Compressing objects: 100% (7/7), done.
            remote: Total 18 (delta 11), reused 18 (delta 11), pack-reused 0
            Unpacking objects: 100% (18/18), done.
            From github.com:lsst/afw
             * [new branch]          tickets/DM-11332 -> origin/tickets/DM-11332
             t [tag update]          w.2017.30        -> w.2017.30
            [master] ~/github/afw $ git show-ref -d w.2017.30
            9099d49766d32f85ae1b917c06874bca7e117534 refs/tags/w.2017.30
            d3ef40641b9102e57e8ba7a88ffac335202b28fd refs/tags/w.2017.30^{}
            
            

            Show
            jhoblitt Joshua Hoblitt added a comment - I manually "tested" the new --force-tag flag github-tag-version by running it against the production repos. github-tag-version --org 'lsst' --team 'Data Management' --email 'sqre-admin@lists.lsst.org' --tagger 'sqreadmin' --debug "w.2017.30" "b2974" --force-tag [master] ~/github/afw $ git fetch --all --tags --prune Fetching origin remote: Counting objects: 18 , done. remote: Compressing objects: 100 % ( 7 / 7 ), done. remote: Total 18 (delta 11 ), reused 18 (delta 11 ), pack-reused 0 Unpacking objects: 100 % ( 18 / 18 ), done. From github.com:lsst/afw * [ new branch] tickets/DM- 11332 -> origin/tickets/DM- 11332 t [tag update] w. 2017.30 -> w. 2017.30 [master] ~/github/afw $ git show-ref -d w. 2017.30 9099d49766d32f85ae1b917c06874bca7e117534 refs/tags/w. 2017.30 d3ef40641b9102e57e8ba7a88ffac335202b28fd refs/tags/w. 2017.30 ^{}
            Hide
            jhoblitt Joshua Hoblitt added a comment -

            It looks like the additional smoke test for building with scons added in DM-11385 broke the tarball build. This has been fixed with a 1 char changeset.

            Show
            jhoblitt Joshua Hoblitt added a comment - It looks like the additional smoke test for building with scons added in DM-11385 broke the tarball build. This has been fixed with a 1 char changeset.
            Hide
            jhoblitt Joshua Hoblitt added a comment -

            Summary of breakage:

            • the weekly release failed when building tarballs (using eups distrib install) due the addition of a test that did not fail gracefully when a setupOptional() test data package was not present
            • when trying to 'retag' the weekly release, it was discovered the github-tag-repos script would exit non-zero upon failed tag operations; and
            • the weekly release script was unable to to move a tag
            • the tarball "smoke tests" were broken last week due to a 1char typo

            Summary of work:

            • the github api library github3.py, used by github-tag-repos needed support for patching a ref (git annotated tag); 2 PRs opened on upstream
            • add github tag error handling and a --fail-fast mode to github-tag-repos
            • add --force-tag mode to github-tag-repos
            • fixed smoke test breakage
            • manually sync eups/git tags + hand held weekly release process
            • change jenkins-dm-jobs to use the new --force-tag mode
            • publishec a fork of github3.py to PYPI as sqre-codekit-github3.py
            • add flake8 linting to sqre-codekit
            • add travis-ci continuous deployment of sqre-codekit to PYPI
            • cut 3.1.0 release of sqre-codekit
            Show
            jhoblitt Joshua Hoblitt added a comment - Summary of breakage: the weekly release failed when building tarballs (using eups distrib install ) due the addition of a test that did not fail gracefully when a setupOptional() test data package was not present when trying to 'retag' the weekly release, it was discovered the github-tag-repos script would exit non-zero upon failed tag operations; and the weekly release script was unable to to move a tag the tarball "smoke tests" were broken last week due to a 1char typo Summary of work: the github api library github3.py , used by github-tag-repos needed support for patching a ref (git annotated tag); 2 PRs opened on upstream add github tag error handling and a --fail-fast mode to github-tag-repos add --force-tag mode to github-tag-repos fixed smoke test breakage manually sync eups/git tags + hand held weekly release process change jenkins-dm-jobs to use the new --force-tag mode publishec a fork of github3.py to PYPI as sqre-codekit-github3.py add flake8 linting to sqre-codekit add travis-ci continuous deployment of sqre-codekit to PYPI cut 3.1.0 release of sqre-codekit

              People

              Assignee:
              jhoblitt Joshua Hoblitt
              Reporter:
              jhoblitt Joshua Hoblitt
              Watchers:
              Frossie Economou, John Swinbank, Joshua Hoblitt, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.