Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-11519

Modify jointcal.py to allow visit Id to be calculated using an camera override.

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: jointcal
    • Labels:
      None

      Description

      jointcal.py uses the visit identifier from its dataRef to group exposures which belong to the same visit. However, in obs_mosaic, there is no visitId, just a set of five keys which together uniquely identify a visit.

      I made a private alternation to jointcal.py to allow the option to create such a unique identifier from a set of dataId keys, and would like to propose that this be incorporated into the main code line.

      John would like to examine the code before he commits one way or the other, so the purpose of this ticket is to allow me to create a branch with my changes which he can easily examine. If he agrees with the concept, we can put this ticket through the normal review process.

        Attachments

          Activity

          Hide
          pgee Perry Gee added a comment -

          Kian-Tat Lim, do you know the answer to this question?

          The situation is that I have a butler and a dataId which I know is adequate to identify a unique calexp. The dataId does not have a "visit" because visit is not a key which is required in my mapper to locate a calexp. However, I do know that there is a visit id in the sqlite database.

          My solution for getting the visit id was: visit = dataRef.getButler().queryMetadata("calexp", ("visit"), dataRef.dataId)[0]

          Do you have a better solution?

          Show
          pgee Perry Gee added a comment - Kian-Tat Lim , do you know the answer to this question? The situation is that I have a butler and a dataId which I know is adequate to identify a unique calexp. The dataId does not have a "visit" because visit is not a key which is required in my mapper to locate a calexp. However, I do know that there is a visit id in the sqlite database. My solution for getting the visit id was: visit = dataRef.getButler().queryMetadata("calexp", ("visit"), dataRef.dataId) [0] Do you have a better solution?
          Hide
          swinbank John Swinbank added a comment -

          Be aware that K-T's on vacation for the next week and a half. You might have better luck getting an answer from Nate.

          Show
          swinbank John Swinbank added a comment - Be aware that K-T's on vacation for the next week and a half. You might have better luck getting an answer from Nate.
          Hide
          npease Nate Pease added a comment -

          This is something you'll have to bring up with K-T.

          Show
          npease Nate Pease added a comment - This is something you'll have to bring up with K-T.
          Hide
          pgee Perry Gee added a comment -

          I'm not that concerned about this. While there might be more straightforward ways to do it, this seems to work fine, and is a well defined part of the API.

          Show
          pgee Perry Gee added a comment - I'm not that concerned about this. While there might be more straightforward ways to do it, this seems to work fine, and is a well defined part of the API.
          Hide
          Parejkoj John Parejko added a comment -

          Sounds good. I've let Russell Owen know to keep the handling of "visit" in mind for the new butler working group.

          Show
          Parejkoj John Parejko added a comment - Sounds good. I've let Russell Owen know to keep the handling of "visit" in mind for the new butler working group.

            People

            • Assignee:
              pgee Perry Gee
              Reporter:
              pgee Perry Gee
              Watchers:
              John Parejko, John Swinbank, Nate Pease, Perry Gee
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel