Details
Description
bin/genCameraRepository.py is broken on master. It fails with:
python bin/genCameraRepository.py megacam/Full_Megacam_geom.paf megacam/camera
|
WARNING: this code generates incorrect vertical overscan; see DM-5524
|
Traceback (most recent call last):
|
File "/Users/rowen/UW/LSST/lsstsw3/stack/DarwinX86/pex_config/13.0-3-g520d906/python/lsst/pex/config/config.py", line 335, in __set__
|
self._validateValue(value)
|
File "/Users/rowen/UW/LSST/lsstsw3/stack/DarwinX86/pex_config/13.0-3-g520d906/python/lsst/pex/config/config.py", line 248, in _validateValue
|
raise TypeError(msg)
|
TypeError: Value DetectorType.SCIENCE is of incorrect type lsst.afw.cameraGeom._detector.DetectorType. Expected type int
|
Also note that the generated file megacam/camera/camera.py is (or was) documented to be auto-generated by that script, so don't touch. However, that file is committed and clearly has been edited, so I plan to update that text as part of DM-5922 and include a TO DO that points to this ticket.
This ticket is a request to do the following:
- Either fix the script or eliminate it.
- Check all other scripts in the bin directory
- Move any scripts that are wanted to new directory bin.src
- Run any relevant scripts as part of scons. Remove any files that will be thus generated from git.
Attachments
Issue Links
Activity
From what I understand from reading DM-5524, I believe it's okay to mark this as WON'T FIX and to remove bin/genCameraRepository.py and the camera geometry PAF file. I was looking at this as part of the pex_policy cleanup in DM-21152. Furthermore, I think the intent is to migrate obs_cfht to YAMLCamera and that will also make this ticket obsolete.
This file was removed in DM-21152.
This is also true for obs_sdss