Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-11560

bin/genCameraRepository.py broken in obs_cfht & obs_sdss

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Invalid
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_cfht, obs_sdss
    • Labels:
      None
    • Team:
      Alert Production

      Description

      bin/genCameraRepository.py is broken on master. It fails with:

      python bin/genCameraRepository.py megacam/Full_Megacam_geom.paf megacam/camera
      		 
      WARNING: this code generates incorrect vertical overscan; see DM-5524
      		 
      Traceback (most recent call last):
      		 
        File "/Users/rowen/UW/LSST/lsstsw3/stack/DarwinX86/pex_config/13.0-3-g520d906/python/lsst/pex/config/config.py", line 335, in __set__
      		 
          self._validateValue(value)
      		 
        File "/Users/rowen/UW/LSST/lsstsw3/stack/DarwinX86/pex_config/13.0-3-g520d906/python/lsst/pex/config/config.py", line 248, in _validateValue
      		 
          raise TypeError(msg)
      		 
      TypeError: Value DetectorType.SCIENCE is of incorrect type lsst.afw.cameraGeom._detector.DetectorType. Expected type int

      Also note that the generated file megacam/camera/camera.py is (or was) documented to be auto-generated by that script, so don't touch. However, that file is committed and clearly has been edited, so I plan to update that text as part of DM-5922 and include a TO DO that points to this ticket.

      This ticket is a request to do the following:

      • Either fix the script or eliminate it.
      • Check all other scripts in the bin directory
      • Move any scripts that are wanted to new directory bin.src
      • Run any relevant scripts as part of scons. Remove any files that will be thus generated from git.

        Attachments

          Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. DM-5524 MegaCam vertical overscan dimensions off by one

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-21152 Remove pex_policy usage when not part of gen2 butler

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-5922 Rework camera geometry to use the replacement for XYTransform

          • Done
          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            rowen Russell Owen created issue -
            rowen Russell Owen made changes -
            Field Original Value New Value
            Link This issue relates to DM-5922 [ DM-5922 ]
            rowen Russell Owen made changes -
            Description bin/genCameraRepository.py is broken on master. It fails with:

            {code}
            python bin/genCameraRepository.py megacam/Full_Megacam_geom.paf megacam/camera
            WARNING: this code generates incorrect vertical overscan; see DM-5524
            Traceback (most recent call last):
              File "/Users/rowen/UW/LSST/lsstsw3/stack/DarwinX86/pex_config/13.0-3-g520d906/python/lsst/pex/config/config.py", line 335, in __set__
                self._validateValue(value)
              File "/Users/rowen/UW/LSST/lsstsw3/stack/DarwinX86/pex_config/13.0-3-g520d906/python/lsst/pex/config/config.py", line 248, in _validateValue
                raise TypeError(msg)
            TypeError: Value DetectorType.SCIENCE is of incorrect type lsst.afw.cameraGeom._detector.DetectorType. Expected type int
            {code}

            Also note that the generated file {{megacam/camera/camera.py}} is (or was) documented to be auto-generated by that script, so don't touch. However, that file is committed and clearly has been edited, so I plan to update that text as part of DM-5922 and include a TO DO that points to this ticket.

            This ticket is a request to do the following:
            - Either fix the script or eliminate it.
            - Check all other scripts in the {{bin}} directory
            - Move any scripts that are wanted to {{bin.scr}}
            - Run any relevant scripts as part of scons. Remove any files that will be thus generated from git.             		bin/genCameraRepository.py is broken on master. It fails with:

            {code}
            python bin/genCameraRepository.py megacam/Full_Megacam_geom.paf megacam/camera
            WARNING: this code generates incorrect vertical overscan; see DM-5524
            Traceback (most recent call last):
              File "/Users/rowen/UW/LSST/lsstsw3/stack/DarwinX86/pex_config/13.0-3-g520d906/python/lsst/pex/config/config.py", line 335, in __set__
                self._validateValue(value)
              File "/Users/rowen/UW/LSST/lsstsw3/stack/DarwinX86/pex_config/13.0-3-g520d906/python/lsst/pex/config/config.py", line 248, in _validateValue
                raise TypeError(msg)
            TypeError: Value DetectorType.SCIENCE is of incorrect type lsst.afw.cameraGeom._detector.DetectorType. Expected type int
            {code}

            Also note that the generated file {{megacam/camera/camera.py}} is (or was) documented to be auto-generated by that script, so don't touch. However, that file is committed and clearly has been edited, so I plan to update that text as part of DM-5922 and include a TO DO that points to this ticket.

            This ticket is a request to do the following:
            - Either fix the script or eliminate it.
            - Check all other scripts in the {{bin}} directory
            - Move any scripts that are wanted to new directory {{bin.src}}
            - Run any relevant scripts as part of scons. Remove any files that will be thus generated from git.
            rowen Russell Owen made changes -
            Component/s obs_sdss [ 10763 ]
            Hide
            Permalink
            rowen Russell Owen added a comment -

            This is also true for obs_sdss

            Show
            rowen Russell Owen added a comment - This is also true for obs_sdss
            swinbank John Swinbank made changes -
            Summary bin/genCameraRepository.py broken bin/genCameraRepository.py broken in obs_cfht & obs_sdss
            swinbank John Swinbank made changes -
            Team Alert Production [ 10300 ]
            swinbank John Swinbank made changes -
            Team Alert Production [ 10300 ] Project Science [ 11800 ]
            swinbank John Swinbank made changes -
            Team Project Science [ 11800 ] Alert Production [ 10300 ]
            rowen Russell Owen made changes -
            Remote Link This issue links to "Page (Confluence)" [ 17025 ]
            tjenness Tim Jenness made changes -
            Link This issue relates to DM-5524 [ DM-5524 ]
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            From what I understand from reading DM-5524, I believe it's okay to mark this as WON'T FIX and to remove bin/genCameraRepository.py and the camera geometry PAF file. I was looking at this as part of the pex_policy cleanup in DM-21152. Furthermore, I think the intent is to migrate obs_cfht to YAMLCamera and that will also make this ticket obsolete.

            Show
            tjenness Tim Jenness added a comment - From what I understand from reading DM-5524 , I believe it's okay to mark this as WON'T FIX and to remove bin/genCameraRepository.py and the camera geometry PAF file. I was looking at this as part of the pex_policy cleanup in DM-21152 . Furthermore, I think the intent is to migrate obs_cfht to YAMLCamera and that will also make this ticket obsolete.
            tjenness Tim Jenness made changes -
            Resolution Done [ 10000 ]
            Status To Do [ 10001 ] Invalid [ 11005 ]
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            This file was removed in DM-21152.

            Show
            tjenness Tim Jenness added a comment - This file was removed in DM-21152 .
            tjenness Tim Jenness made changes -
            Link This issue relates to DM-21152 [ DM-21152 ]

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              rowen Russell Owen
              Watchers:
              Russell Owen, Simon Krughoff, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.