Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-11574

Make testDistortion test the distortion

    Details

    • Templates:
    • Story Points:
      1
    • Sprint:
      Alert Production F17 - 8
    • Team:
      Alert Production

      Description

      The unit test testDistortion.py tests a few things but those do not include the actual distortion computation (instead it prints a series of values that includes an error. The test contains outdated data (the camera geometry has changed) so some error values are unreasonably large.

      I propose to do the following:

      • Update the test to optionally write the expected results to a file (e.g. by setting a constant).
      • Have the test read the data from a file instead of as text in the file.
      • Instead of printing output it will test on the difference.

      Unfortunately this assumes that the current distortion function operates correctly, so it's not quite as thorough a test as we might like, but it will be an improvement and will greatly help DM-5922 which changes to a new distortion function.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                rowen Russell Owen
                Reporter:
                rowen Russell Owen
                Reviewers:
                Paul Price
                Watchers:
                Paul Price, Russell Owen
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel