Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-11577

newinstall.sh fails if a pre-exisitng python is not in the path

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Continuous Integration
    • Labels:
      None

      Description

      [vagrant@jhoblitt-skc-f25 ~]$ which python
      /usr/bin/which: no python in (/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/opt/puppetlabs/bin:/home/vagrant/.local/bin:/home/vagrant/bin)
      [vagrant@jhoblitt-skc-f25 ~]$ /opt/lsst/software/stack/newinstall.sh -b
       
      LSST Software Stack Builder
      =======================================================================
       
      ######################################################################## 100.0%
      Detected git version 2.9.4. OK.
       
      /opt/lsst/software/stack/newinstall.sh: line 569: python: command not found
      
      

        Attachments

          Issue Links

            Activity

            Hide
            jhoblitt Joshua Hoblitt added a comment -

            I spent some time trying to smooth out the python version checking / notifications in addition to merely fixing the blind invocation of python. It is worth nothing that it would simplify the script to give up on sanity checking a path python and simply always install miniconda.

            Show
            jhoblitt Joshua Hoblitt added a comment - I spent some time trying to smooth out the python version checking / notifications in addition to merely fixing the blind invocation of python . It is worth nothing that it would simplify the script to give up on sanity checking a path python and simply always install miniconda.
            Hide
            jhoblitt Joshua Hoblitt added a comment -

            Could one of (Tim Jenness, John Swinbank) review the GH PR?

            I tested the changes on this ticket by hand but confess that newinstall.sh is, and long has been, in need of a testing framework. I've identified several bash testing frameworks but some experimentation is needed to make a selection.

            Show
            jhoblitt Joshua Hoblitt added a comment - Could one of ( Tim Jenness , John Swinbank ) review the GH PR? I tested the changes on this ticket by hand but confess that newinstall.sh is, and long has been, in need of a testing framework. I've identified several bash testing frameworks but some experimentation is needed to make a selection.
            Hide
            swinbank John Swinbank added a comment -

            Looks basically fine. I think there's an error in the argument handling in n8l::pyverok which is being hidden because it's falling back to defaults. Couple of other trivial comments on the PR.

            Show
            swinbank John Swinbank added a comment - Looks basically fine. I think there's an error in the argument handling in n8l::pyverok which is being hidden because it's falling back to defaults. Couple of other trivial comments on the PR.
            Hide
            jhoblitt Joshua Hoblitt added a comment -

            After addressing all the GH PR comments, I concluded that basic unit testing was badly needed and did a quick review of bash testing frameworks. The only framework I was able to identify that supported "mocking" was rspec-bash. I've add rspec coverage for the new and modified functions + converted the "manual" unit tests for miniconda::install's handling of mktemp.

            Show
            jhoblitt Joshua Hoblitt added a comment - After addressing all the GH PR comments, I concluded that basic unit testing was badly needed and did a quick review of bash testing frameworks. The only framework I was able to identify that supported "mocking" was rspec-bash . I've add rspec coverage for the new and modified functions + converted the "manual" unit tests for miniconda::install 's handling of mktemp .

              People

              Assignee:
              jhoblitt Joshua Hoblitt
              Reporter:
              jhoblitt Joshua Hoblitt
              Reviewers:
              John Swinbank, Tim Jenness
              Watchers:
              John Swinbank, Joshua Hoblitt, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.