Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-11595

daf_persistence tests fail with pytest-xdist

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: daf_persistence
    • Labels:
      None
    • Story Points:
      3
    • Sprint:
      DB_S17_8
    • Team:
      Architecture

      Description

      With DM-11514, we get tests run in parallel using pytest-xdist. This seems to cause individual tests to be parallelized in multiple processes, leading to the daf_persistence tests failing because they assume that a single temp directory can be used for all tests in a single class.

      We need to change this so that setUp allocates a proper temp directory with a unique name.

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            Nate Pease I'll take this ticket on. I'm almost done with it and then I'll ask you to review.

            Show
            tjenness Tim Jenness added a comment - Nate Pease I'll take this ticket on. I'm almost done with it and then I'll ask you to review.
            Hide
            tjenness Tim Jenness added a comment -

            Nate Pease I think this is ready for review now. I can no longer get the tests to fail when run using 1 to 12 processes.

            Show
            tjenness Tim Jenness added a comment - Nate Pease I think this is ready for review now. I can no longer get the tests to fail when run using 1 to 12 processes.
            Hide
            npease Nate Pease added a comment -

            Overall there the changes are good. There's a few things that need cleanup.

            Show
            npease Nate Pease added a comment - Overall there the changes are good. There's a few things that need cleanup.
            Hide
            npease Nate Pease added a comment -

            I reviewed, and made a few changes after discussing with Tim.

            Show
            npease Nate Pease added a comment - I reviewed, and made a few changes after discussing with Tim.

              People

              • Assignee:
                tjenness Tim Jenness
                Reporter:
                tjenness Tim Jenness
                Reviewers:
                Nate Pease
                Watchers:
                Nate Pease, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel