Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-11625

Bug in calculation of number-of-detected-in-bands in peak culling

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_tasks
    • Labels:
      None

      Description

      HSC internal release processing uncovered a bug in our peak culling in MergeCoaddDetectionsTask, due to a schema string with periods instead of underscores. The result is that when testing how many bands a source appears to have been detected in, the result is always zero.

      This has apparently been present on the LSST for a long time (possibly since the code was ported there), and has gone unnoticed because this test is only operative in the very largest blends, which are moderately rare in the Wide survey. We certainly should have spotted it in the UltraDeep RC tests, however; we need to make sure our RC tests include checking for changes in the number or density of detected sources.

        Attachments

          Issue Links

            Activity

            Hide
            jbosch Jim Bosch added a comment -

            Paul Price, could you take a look? Would have been a two-character diff but for the assert I added to keep it from happening again.

            I'll run through Jenkins now. I have not yet verified that this fixes the problem, but if you can get this in an HSC bugfix release, perhaps we can ask NAOJ to do that?

            Show
            jbosch Jim Bosch added a comment - Paul Price , could you take a look? Would have been a two-character diff but for the assert I added to keep it from happening again. I'll run through Jenkins now. I have not yet verified that this fixes the problem, but if you can get this in an HSC bugfix release, perhaps we can ask NAOJ to do that?
            Hide
            price Paul Price added a comment -

            Awesome!

            Super-minor suggestion on the GitHub PR.

            Show
            price Paul Price added a comment - Awesome! Super-minor suggestion on the GitHub PR.
            Hide
            jbosch Jim Bosch added a comment -

            Merged to master after successful Jenkins run.

            Show
            jbosch Jim Bosch added a comment - Merged to master after successful Jenkins run.

              People

              Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Paul Price
              Watchers:
              Bob Armstrong, Jim Bosch, Paul Price, Robert Lupton
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: