Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-11667

daf_persistence relies on pex_exceptions installing import aliases

    XMLWordPrintable

    Details

    • Team:
      Architecture

      Description

      DM-11658 removed a seemingly irrelevant request to install alias packages for python3/python2 support. It seems that this is a global action for the python importer and that packages downstream of pex_exceptions were relying on something else installing the aliases.

      Since this is a global compatibility change for all packages, I'm now wondering if we aren't better off calling this once in the base package. Calling install_aliases in each package is annoying because the linter gets upset that the command is run before all imports have finished.

      I'm sorry I broke the build. It hadn't occurred to me that downstream packages were relying on an earlier package installing this.

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            I have a patch that fixes this. Patching base seems to work fine.

            Show
            tjenness Tim Jenness added a comment - I have a patch that fixes this. Patching base seems to work fine.
            Hide
            tjenness Tim Jenness added a comment -

            Tested on jenkins. Works okay so merging without review since this is breaking master.

            Show
            tjenness Tim Jenness added a comment - Tested on jenkins. Works okay so merging without review since this is breaking master.

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              tjenness Tim Jenness
              Watchers:
              Colin Slater, Ian Sullivan, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: