Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-11745

Investigate wrapping external function calls in ap_verify

    Details

    • Story Points:
      2
    • Epic Link:
    • Sprint:
      Alert Production F17 - 9, Alert Production F17 - 10, Alert Production F17 - 11, AP S18-1
    • Team:
      Alert Production

      Description

      As discussed in https://jira.lsstcorp.org/browse/DM-10779, it may be possible to minimize code duplication in ap_verify by using a wrapper function to perform appropriate metrics handling on the library calls to ap_pipe. This ticket is to investigate the utility of such an approach.

        Attachments

          Issue Links

            Activity

            Hide
            krzys Krzysztof Findeisen added a comment -

            Hi Eric Bellm, can you take a look at what I did for this, since you're the most likely to object? I realize you're travelling, but this isn't urgent.

            I've also included a fix to ap_verify's avoidance of camel-case, but I don't expect that to be controversial.

            Show
            krzys Krzysztof Findeisen added a comment - Hi Eric Bellm , can you take a look at what I did for this, since you're the most likely to object? I realize you're travelling, but this isn't urgent. I've also included a fix to ap_verify 's avoidance of camel-case, but I don't expect that to be controversial.
            Hide
            krzys Krzysztof Findeisen added a comment -

            Setting this ticket back to "In Progress", because the "fix the names to camelCase" commit must not be done concurrently with other work on ap_verify. I'll redo and resubmit it right after the MVS deadline.

            Show
            krzys Krzysztof Findeisen added a comment - Setting this ticket back to "In Progress", because the "fix the names to camelCase" commit must not be done concurrently with other work on ap_verify . I'll redo and resubmit it right after the MVS deadline.
            Hide
            krzys Krzysztof Findeisen added a comment -

            Placing this ticket in review again. The camel-casing was taken care of on DM-11592, so the diff is now much cleaner.

            (Eric Bellm, I promise this is the last review. But since this is a fix to an issue you reported, I really shouldn't give it to someone else...)

            Show
            krzys Krzysztof Findeisen added a comment - Placing this ticket in review again. The camel-casing was taken care of on DM-11592 , so the diff is now much cleaner. ( Eric Bellm , I promise this is the last review. But since this is a fix to an issue you reported, I really shouldn't give it to someone else...)
            Hide
            ebellm Eric Bellm added a comment -

            looks good.

            Show
            ebellm Eric Bellm added a comment - looks good.
            Hide
            krzys Krzysztof Findeisen added a comment -

            Thanks for the quick response!

            Show
            krzys Krzysztof Findeisen added a comment - Thanks for the quick response!

              People

              • Assignee:
                krzys Krzysztof Findeisen
                Reporter:
                ebellm Eric Bellm
                Reviewers:
                Eric Bellm
                Watchers:
                Eric Bellm, Krzysztof Findeisen
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: