Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-11895

Support getting data for current card of FitsChan

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: astshim
    • Story Points:
      3
    • Epic Link:
    • Sprint:
      Alert Production F17 - 9
    • Team:
      Alert Production

      Description

      AST astGetFits<X> functions (astGetFitsS, astGetFitsF, etc.) take a name to specify which FITS card to read; if the name (a char *) is NULL then the current card is read. astshim does not yet support the ability to read the current card, and it is very useful; in particular it would be a big help for DM-10765. I propose to add this functionality as follows:

      • if name is "" then read the current card
      • name will default to ""
      • In the pybind11 wrapper allow name=None, which will be the default

      In addition, the most recent version of AST enhances astTestFits to support name=NULL for the current card. Add similar support to astshim, as above.

      An obvious alternative is to add an overload for each FitsChan.getFIts<X> that has no name argument. That is arguably a bit more C++-like, but in my opinion it adds too many new member functions to be worthwhile. Plus overloads make the Python interface a bit harder to understand.

        Attachments

          Issue Links

            Activity

            rowen Russell Owen created issue -
            rowen Russell Owen made changes -
            Field Original Value New Value
            Epic Link DM-9679 [ 30784 ]
            rowen Russell Owen made changes -
            Link This issue relates to DM-10765 [ DM-10765 ]
            rowen Russell Owen made changes -
            Link This issue blocks DM-10765 [ DM-10765 ]
            rowen Russell Owen made changes -
            Link This issue relates to DM-10765 [ DM-10765 ]
            rowen Russell Owen made changes -
            Comment [ I gave up on the idea of supporting {{name=None}} in Python for {{FitsChan.getFits<X>}} and {{testFits}}. It can be done but it's rather messy and I don't think it's worth the work. ]
            rowen Russell Owen made changes -
            Reviewers Fred Moolekamp [ fred3m ]
            Status To Do [ 10001 ] In Review [ 10004 ]
            fred3m Fred Moolekamp made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            rowen Russell Owen made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              • Assignee:
                rowen Russell Owen
                Reporter:
                rowen Russell Owen
                Reviewers:
                Fred Moolekamp
                Watchers:
                Fred Moolekamp, Russell Owen
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel