Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-11902

LSST Eigen installs are not discoverable by cmake

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: eigen
    • Labels:
      None
    • Story Points:
      1
    • Sprint:
      DRP F17-4, DRP F17-5
    • Team:
      Data Release Production

      Description

      Our Eigen package has an all-too-clever eupspkg.cfg.sh that "emulates" the CMake build that comes with Eigen - and fails to install files that other CMake packages can use to find it.

      This was discovered while testing an external PR on ndarray that improves and cleans up its CMake build.

      My planned solution is to simply remove the eupspkg.sh and let Eigen's CMake build do its thing.

        Attachments

          Activity

          Hide
          jbosch Jim Bosch added a comment -

          Nate Lust, here's what should hopefully be a quick review: it's a rewrite of the build script for Eigen to delegate more to Eigen's CMake installer, which, while simple, is still not something I think we want to emulate.

          Show
          jbosch Jim Bosch added a comment - Nate Lust , here's what should hopefully be a quick review: it's a rewrite of the build script for Eigen to delegate more to Eigen's CMake installer, which, while simple, is still not something I think we want to emulate.
          Hide
          nlust Nate Lust added a comment -

          Just one comment up on github pull request

          Show
          nlust Nate Lust added a comment - Just one comment up on github pull request
          Hide
          jbosch Jim Bosch added a comment -

          All comments addressed, CI run successfully, merged to master.

          Show
          jbosch Jim Bosch added a comment - All comments addressed, CI run successfully, merged to master.

            People

            • Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Nate Lust
              Watchers:
              Jim Bosch, Nate Lust
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel