Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-11911

Update obs_ctio0m9 to work following DM-5922

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_base, obs_ctio0m9
    • Labels:
      None

      Description

      DM-5922 changes the cameraGeometry model, and obs_ctio0m9 needs updating to work with this, (as did most/all of the other obs_packages - somehow this one just got forgotten).

      Also, scripts in the /scripts dir should be exectuable.

      Also also, it shouldn't have its own yamlCamera, that has now been moved to obs_base following DM-11196, so change to import from there

        Attachments

          Issue Links

          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-5922 Rework camera geometry to use the replacement for XYTransform

          • Done
          relates to

          Improvement - An improvement or enhancement to an existing feature or task. DM-12085 Camera geometry incorrect and outdated in obs_test

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            mfisherlevine Merlin Fisher-Levine added a comment -

            See the changes made in the PRs to the various obs_packages in DM-5922 to see how this is done (i.e. this is a good way to cheat here)

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - See the changes made in the PRs to the various obs_packages in DM-5922 to see how this is done ( i.e. this is a good way to cheat here)
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            It was forgotten because no-one has added it to the lsst_obs metapackage yet.

            Show
            tjenness Tim Jenness added a comment - It was forgotten because no-one has added it to the lsst_obs metapackage yet.
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Unfortunately the code you updated in obs_base had a pre-existing bug – the transform between pixels and focal plane was inverted. Fortunately fixing it simplifies your new code a bit. However, the fact that you have been running (a copy of) the incorrect code in obs_ctio0m9 worries me.

            Show
            rowen Russell Owen added a comment - Unfortunately the code you updated in obs_base had a pre-existing bug – the transform between pixels and focal plane was inverted. Fortunately fixing it simplifies your new code a bit. However, the fact that you have been running (a copy of) the incorrect code in obs_ctio0m9 worries me.
            Hide
            Permalink
            mfisherlevine Merlin Fisher-Levine added a comment -

            Merged!

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - Merged!

              People

              Assignee:
              mfisherlevine Merlin Fisher-Levine
              Reporter:
              mfisherlevine Merlin Fisher-Levine
              Reviewers:
              Russell Owen
              Watchers:
              Augustin Guyonnet [X] (Inactive), John Swinbank, Merlin Fisher-Levine, Russell Owen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.