Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-11927

Set maxOffsetPix consistently

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_subaru
    • Labels:
      None
    • Team:
      External

      Description

      In an RC run, Hsin-Fang Chiang discovered four CCDs that didn't complete ProcessCcdTask but did before, and pointed out:

      Both old and new have `calibrate.astrometry.matcher.maxOffsetPix=250` and `calibrate.photoCal.matcher.maxOffsetPix=300`. Does it matter one is 250 and the other is 300?

        Attachments

          Issue Links

            Activity

            Hide
            price Paul Price added a comment - - edited

            pprice@lsst-dev01:~/LSST/obs/subaru[tickets/DM-11927] $ git sub
            commit 8fd8481a642ad8209e7b1c842ff54edba9fd6d1a
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Fri Sep 15 13:26:09 2017 -0500
             
                config: make matching consistent
                
                ProcessCcdTask uses multiple matchers; make their configuration consistent.
                Especially important is 'maxOffsetPix=250', which has been shown to be the
                sweet spot, and if some matchers don't have this set they can fail.
                
                Bug discovered and diagnosed by Hsin-Fang Chiang.
             
             config/hsc/processCcd.py | 14 +++++++++-----
             1 file changed, 9 insertions(+), 5 deletions(-)
            

            Show
            price Paul Price added a comment - - edited pprice@lsst-dev01:~/LSST/obs/subaru[tickets/DM-11927] $ git sub commit 8fd8481a642ad8209e7b1c842ff54edba9fd6d1a Author: Paul Price <price@astro.princeton.edu> Date: Fri Sep 15 13:26:09 2017 -0500   config: make matching consistent ProcessCcdTask uses multiple matchers; make their configuration consistent. Especially important is 'maxOffsetPix=250', which has been shown to be the sweet spot, and if some matchers don't have this set they can fail. Bug discovered and diagnosed by Hsin-Fang Chiang.   config/hsc/processCcd.py | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-)
            Hide
            hchiang2 Hsin-Fang Chiang added a comment -

            Using w_2017_36 with this ticket change, I checked the 6 cases that ProcessCcd outcome changed in w_2017_36 (DM-11189).

            For the 4 that failed in w_2017_36 but passed in w_2017_34 (--id visit=24304 ccd=70 --id visit=28374 ccd=101 --id visit=28386 ccd=103 --id visit=9868 ccd=77), they now all passed.

            For the 2 that failed in w_2017_34 but passed in w_2017_36 (--id visit=1206 ccd=77 --id visit=29324 ccd=99), they still pass with this ticket.

            So they are not identical with before DM-11356 (differenses in photoCal.matcher) but it's better. And I think it makes sense to have all matchers consistent too.

            Show
            hchiang2 Hsin-Fang Chiang added a comment - Using w_2017_36 with this ticket change, I checked the 6 cases that ProcessCcd outcome changed in w_2017_36 ( DM-11189 ). For the 4 that failed in w_2017_36 but passed in w_2017_34 ( --id visit=24304 ccd=70 --id visit=28374 ccd=101 --id visit=28386 ccd=103 --id visit=9868 ccd=77 ), they now all passed. For the 2 that failed in w_2017_34 but passed in w_2017_36 ( --id visit=1206 ccd=77 --id visit=29324 ccd=99 ), they still pass with this ticket. So they are not identical with before DM-11356 (differenses in photoCal.matcher) but it's better. And I think it makes sense to have all matchers consistent too.
            Hide
            price Paul Price added a comment -

            Thanks Hsin-Fang Chiang!

            Merged to master.

            Show
            price Paul Price added a comment - Thanks Hsin-Fang Chiang ! Merged to master.

              People

              Assignee:
              price Paul Price
              Reporter:
              price Paul Price
              Reviewers:
              Hsin-Fang Chiang
              Watchers:
              Hsin-Fang Chiang, Paul Price
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.