Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-11931

Fix jointcal exit status and doRaise handling

    XMLWordPrintable

    Details

      Description

      jointcal is giving these warnings since DM-4141 was implemented:

      Unable to retrieve exit status ('Struct' object has no attribute 'exitStatus')

      To fix this, I think I need to do the following:

      • add this to the start of run: exitStatus = 0 # exit status for shell
      • add exitStatus to the returned Struct
      • wrap most of run in try: except:
      • set exitStatus=1 (or some other number) if doRaise is False and something went wrong.

      Anything else I'm missing?

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-12310 Figure out why most HSC datasets start with photometry chi2==NaN

          • Done
          is triggered by

          Improvement - An improvement or enhancement to an existing feature or task. DM-4141 cmdLineTasks should provide proper unix return codes

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Having this will help me come up with a good solution for DM-12310

            Show
            Parejkoj John Parejko added a comment - Having this will help me come up with a good solution for DM-12310
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Hsin-Fang Chiang: Can you review this? You were involved in the original addition of exitStatus handling in pipe_base, so I thought you might have some insight here. Most of the changes are new tests, plus some cleanup of the error messages in pipe_base.

            Show
            Parejkoj John Parejko added a comment - Hsin-Fang Chiang : Can you review this? You were involved in the original addition of exitStatus handling in pipe_base, so I thought you might have some insight here. Most of the changes are new tests, plus some cleanup of the error messages in pipe_base.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/26948/pipeline

            Show
            Parejkoj John Parejko added a comment - jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/26948/pipeline
            Hide
            Permalink
            hchiang2 Hsin-Fang Chiang added a comment -

            changes look okay to me

            Show
            hchiang2 Hsin-Fang Chiang added a comment - changes look okay to me
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Thanks for the quick review!

            I'll wait to see if Robert Lupton has anything to say before merging.

            Happier Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/26951/pipeline/

            Show
            Parejkoj John Parejko added a comment - Thanks for the quick review! I'll wait to see if Robert Lupton has anything to say before merging. Happier Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/26951/pipeline/
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Merged and done.

            Show
            Parejkoj John Parejko added a comment - Merged and done.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Hsin-Fang Chiang
              Watchers:
              Hsin-Fang Chiang, John Parejko, John Swinbank, Paul Price, Robert Lupton
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.