# Fix jointcal exit status and doRaise handling

XMLWordPrintable

#### Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
• Story Points:
2
• Sprint:
Alert Production F17 - 10
• Team:

#### Description

jointcal is giving these warnings since DM-4141 was implemented:

 Unable to retrieve exit status ('Struct' object has no attribute 'exitStatus') 

To fix this, I think I need to do the following:

• add this to the start of run: exitStatus = 0 # exit status for shell
• add exitStatus to the returned Struct
• wrap most of run in try: except:
• set exitStatus=1 (or some other number) if doRaise is False and something went wrong.

Anything else I'm missing?

#### Activity

Hide
John Parejko added a comment -

Having this will help me come up with a good solution for DM-12310

Show
John Parejko added a comment - Having this will help me come up with a good solution for DM-12310
Hide
John Parejko added a comment -

Hsin-Fang Chiang: Can you review this? You were involved in the original addition of exitStatus handling in pipe_base, so I thought you might have some insight here. Most of the changes are new tests, plus some cleanup of the error messages in pipe_base.

Show
John Parejko added a comment - Hsin-Fang Chiang : Can you review this? You were involved in the original addition of exitStatus handling in pipe_base, so I thought you might have some insight here. Most of the changes are new tests, plus some cleanup of the error messages in pipe_base.
Hide
John Parejko added a comment -
Show
John Parejko added a comment - jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/26948/pipeline
Hide
Hsin-Fang Chiang added a comment -

changes look okay to me

Show
Hsin-Fang Chiang added a comment - changes look okay to me
Hide
John Parejko added a comment -

Thanks for the quick review!

I'll wait to see if Robert Lupton has anything to say before merging.

Show
John Parejko added a comment - Thanks for the quick review! I'll wait to see if Robert Lupton has anything to say before merging. Happier Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/26951/pipeline/
Hide
John Parejko added a comment -

Merged and done.

Show
John Parejko added a comment - Merged and done.

#### People

Assignee:
John Parejko
Reporter:
John Parejko
Reviewers:
Hsin-Fang Chiang
Watchers:
Hsin-Fang Chiang, John Parejko, John Swinbank, Paul Price, Robert Lupton