Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-11951

Fixes in AL Decorrelation and Zogy

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ip_diffim
    • Labels:
      None

      Description

      Fixes to AL Decorrelation and Zogy implementations discovered during refactor DM-3704 and DMTN writeup DM-11813

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-11813 Summary of A&L Decorrelation and Zogy

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-3704 Refactor ImageDifferenceTask: Split into two tasks

          • Won't Fix

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            reiss David Reiss added a comment -

            These updates have had four beneficial effects which have all been tested on a real DECam data set:

            1. Improved run-time on spatially-varying calculations due to decrease in number of grid elements used
            2. Improved robustness of Zogy due to removal of division-by-small-number issues and enforcing same-centroid-pixels for both PSFs
            3. Improved robustness of AL Decorrelation due to same as (2)
            4. Enabling "doPreConvolve" with decorrelation and Zogy from the imageDifference.py config.

            Show
            reiss David Reiss added a comment - These updates have had four beneficial effects which have all been tested on a real DECam data set: 1. Improved run-time on spatially-varying calculations due to decrease in number of grid elements used 2. Improved robustness of Zogy due to removal of division-by-small-number issues and enforcing same-centroid-pixels for both PSFs 3. Improved robustness of AL Decorrelation due to same as (2) 4. Enabling "doPreConvolve" with decorrelation and Zogy from the imageDifference.py config.
            Hide
            Permalink
            reiss David Reiss added a comment -

            Passed Jenkins: https://ci.lsst.codes/job/stack-os-matrix/26729/

            Show
            reiss David Reiss added a comment - Passed Jenkins: https://ci.lsst.codes/job/stack-os-matrix/26729/
            Hide
            Permalink
            reiss David Reiss added a comment -

            Hi Russell, as you suggested earlier today I moved all of my algorithm bug-fix code to a different branch (out of the imageDifference refactor) and now I'm hoping you'd be willing to review it? It is not a very large amount of code. Thank you!

            Show
            reiss David Reiss added a comment - Hi Russell, as you suggested earlier today I moved all of my algorithm bug-fix code to a different branch (out of the imageDifference refactor) and now I'm hoping you'd be willing to review it? It is not a very large amount of code. Thank you!
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Overall this looks nice. I had a few small suggestions.

            Show
            rowen Russell Owen added a comment - Overall this looks nice. I had a few small suggestions.
            Hide
            Permalink
            reiss David Reiss added a comment -

            Thanks very much for the review, Russell Owen. I have made the changes you suggested and/or responded to your comments/questions.

            Show
            reiss David Reiss added a comment - Thanks very much for the review, Russell Owen . I have made the changes you suggested and/or responded to your comments/questions.
            Hide
            Permalink
            reiss David Reiss added a comment -

            Re-ran jenkins just to double-check, and it pass the ip_diffim build:

            https://ci.lsst.codes/job/stack-os-matrix/26737/

            so I will now merge.

            Show
            reiss David Reiss added a comment - Re-ran jenkins just to double-check, and it pass the ip_diffim build: https://ci.lsst.codes/job/stack-os-matrix/26737/ so I will now merge.

              People

              Assignee:
              reiss David Reiss
              Reporter:
              reiss David Reiss
              Reviewers:
              Russell Owen
              Watchers:
              David Reiss, Eric Bellm, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: