Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-11957

Cannot round-trip >7th degree Chebyshev photometry models

    Details

    • Story Points:
      3
    • Sprint:
      Alert Production F17 - 9, Alert Production F17 - 10
    • Team:
      Alert Production

      Description

      If I set photometryVisitDegree > 7 in jointcal's ConstrainedPhotometryModel, I receive RuntimeError: Could not read an AST object from this channel when trying to unpersist the PhotoCalib object containing the TransformPoint2ToGeneric that I had written via butler.put('photoCalib', photoCalib). I will attach example files produced with degree=7 and 11, to help with debugging.

        Attachments

          Issue Links

            Activity

            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            The problem is that the default character encoding is implementation defined. So the same bytes may correspond to different characters on different platforms / compilers. In practice I don't think it will be a problem, since it is almost always ASCII or UTF8. But it may be a problem. The safe thing to do would be to explicitly convert from the native encoding to UTF8 (which is probably a noop) before storing and then back again on loading. But I don't know if we need to jump through such hoops. There is remarkably little literature on the topic.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - The problem is that the default character encoding is implementation defined. So the same bytes may correspond to different characters on different platforms / compilers. In practice I don't think it will be a problem, since it is almost always ASCII or UTF8. But it may be a problem. The safe thing to do would be to explicitly convert from the native encoding to UTF8 (which is probably a noop) before storing and then back again on loading. But I don't know if we need to jump through such hoops. There is remarkably little literature on the topic.
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment - - edited

            Ok, so I talked it over with Jim Bosch and we agreed that it probably isn't an issue. But please do file a separate ticket to look into it at some point.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - - edited Ok, so I talked it over with Jim Bosch and we agreed that it probably isn't an issue. But please do file a separate ticket to look into it at some point.
            Hide
            rowen Russell Owen added a comment -

            That seems very reasonable. I filed DM-12072 to look into this issue.

            Show
            rowen Russell Owen added a comment - That seems very reasonable. I filed DM-12072 to look into this issue.
            Hide
            rowen Russell Owen added a comment -

            Pim Schellart [X] your remaining suggestions appear to be out of scope for this ticket. I'll ask you to file tickets for them, since I think you understand what you want better than I do.

            Show
            rowen Russell Owen added a comment - Pim Schellart [X] your remaining suggestions appear to be out of scope for this ticket. I'll ask you to file tickets for them, since I think you understand what you want better than I do.
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            Will do.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Will do.

              People

              • Assignee:
                rowen Russell Owen
                Reporter:
                Parejkoj John Parejko
                Reviewers:
                Pim Schellart [X] (Inactive)
                Watchers:
                Jim Bosch, John Parejko, John Swinbank, Pim Schellart [X] (Inactive), Russell Owen, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel