Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-12006

Improve testing of copyPolymorphic

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: astshim
    • Templates:
    • Story Points:
      0.5
    • Sprint:
      AP F18-2
    • Team:
      Alert Production

      Description

      While working on DM-11971 I found that CmpMap was missing an override of copyPolymorphic. Improve the unit tests so this would be caught.

      Consider removing the definition of copyPolymporphic and copy from Mapping, since that class is abstract. This may make it easier to detect omission in subclasses of Mapping, since such code will not compile. However, that still leaves deeper classes that could forget to override it, so unit testing is more important.

      Finally, remove the virtual since it is implied by override.

      Consider adding explicit @copydoc to copyPolymorphic, though Doxygen already shows the documentation.

        Attachments

          Container Issues

            Issue Links

              Activity

                People

                • Assignee:
                  rowen Russell Owen
                  Reporter:
                  rowen Russell Owen
                  Reviewers:
                  Krzysztof Findeisen
                  Watchers:
                  Krzysztof Findeisen, Russell Owen, Tim Jenness
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Summary Panel