Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-12022

tarball build "smoke test" failing on v14_0_rc2

    Details

      Description

      A "tarball" build of v14_0_rc2 is failing in the scons smoke test. Presumably, due to the smoke test using lsst/base on master, which has since diverged from the v14 branch.

      ++ scons
      scons: Reading SConscript files ...
      EUPS integration: enabled
      Checking who built the CC compiler...gcc=4.8.5
      CC is gcc version 4.8.5
      Checking for C++11 support
      Checking whether the C++ compiler works... yes
      C++11 supported with '-std=c++11'
      Setting up environment to build package 'base'.
      TypeError: tests() got an unexpected keyword argument 'pySingles':
        File "/smoke/base/SConstruct", line 4:
          scripts.BasicSConstruct("base")
        File "/smoke/stack/miniconda3-4.3.21-10a4fa6/Linux64/sconsUtils/13.0-7-gc601e82+1/python/lsst/sconsUtils/scripts.py", line 65:
          versionModuleName, noCfgFile=noCfgFile, sconscriptOrder=sconscriptOrder)
        File "/smoke/stack/miniconda3-4.3.21-10a4fa6/Linux64/sconsUtils/13.0-7-gc601e82+1/python/lsst/sconsUtils/scripts.py", line 137:
          SConscript(script)
        File "/smoke/stack/miniconda3-4.3.21-10a4fa6/Linux64/scons/2.5.0.lsst2+1/lib/scons/SCons/Script/SConscript.py", line 604:
          return method(*args, **kw)
        File "/smoke/stack/miniconda3-4.3.21-10a4fa6/Linux64/scons/2.5.0.lsst2+1/lib/scons/SCons/Script/SConscript.py", line 541:
          return _SConscript(self.fs, *files, **subst_kw)
        File "/smoke/stack/miniconda3-4.3.21-10a4fa6/Linux64/scons/2.5.0.lsst2+1/lib/scons/SCons/Script/SConscript.py", line 250:
          exec _file_ in call_stack[-1].globals
        File "/smoke/base/tests/SConscript", line 6:
          pySingles=['testModuleImporter2.py'], pyList=[])
      

        Attachments

          Activity

          Hide
          jhoblitt Joshua Hoblitt added a comment -
          Show
          jhoblitt Joshua Hoblitt added a comment - A test build is in progress: https://ci.lsst.codes/job/release/job/tarball-matrix/1/
          Hide
          jhoblitt Joshua Hoblitt added a comment -

          The regex added to parse the base package version is missing an important case and is broken.

          Show
          jhoblitt Joshua Hoblitt added a comment - The regex added to parse the base package version is missing an important case and is broken.
          Hide
          jhoblitt Joshua Hoblitt added a comment -

          The fix for the observed failure was easy but after looking through all the version strings in a lsst_distrb install, there are other format variants that also need to be handled.

          diff --git a/pipelines/release/tarball.groovy b/pipelines/release/tarball.groovy
          index aff510e..2e65434 100644
          --- a/pipelines/release/tarball.groovy
          +++ b/pipelines/release/tarball.groovy
          @@ -544,6 +544,7 @@ def String smokeScript(
               # - 13.0 as 13.0
               # - 13.0+1 as 13.0
               # - 13.0-10-g692d0a9 as 692d0a9
          +    # - 13.0-10-g692d0a9+1 as 692d0a9
               #
               # Eg.
               #    13.0-10-692d0a9 d_2017_09_14 ... current d_2017_09_13
          @@ -553,7 +554,7 @@ def String smokeScript(
               BASE_REF=$(eups list base | python -c "
           import sys,re;
           for line in sys.stdin:
          -  foo = re.sub(r'^\\s*(?:[\\d.-]+g(\\S+)|([\\d.]+)\\+?[\\d]*)\\s+.*', lambda m: m.group(1) or m.group(2), line)
          +  foo = re.sub(r'^\\s*(?:[\\d.-]+g([a-zA-Z0-9]+)|([\\d.]+))(?:\\+[\\d]+)?\\s+.*', lambda m: m.group(1) or m.group(2), line)
             if foo is line:
               sys.exit(1)
             print(foo)
          

          Show
          jhoblitt Joshua Hoblitt added a comment - The fix for the observed failure was easy but after looking through all the version strings in a lsst_distrb install, there are other format variants that also need to be handled. diff --git a/pipelines/release/tarball.groovy b/pipelines/release/tarball.groovy index aff510e..2e65434 100644 --- a/pipelines/release/tarball.groovy +++ b/pipelines/release/tarball.groovy @@ - 544 , 6 + 544 , 7 @@ def String smokeScript( # - 13.0 as 13.0 # - 13.0 + 1 as 13.0 # - 13.0 - 10 -g692d0a9 as 692d0a9 + # - 13.0 - 10 -g692d0a9+ 1 as 692d0a9 # # Eg. # 13.0 - 10 -692d0a9 d_2017_09_14 ... current d_2017_09_13 @@ - 553 , 7 + 554 , 7 @@ def String smokeScript( BASE_REF=$(eups list base | python -c " import sys,re; for line in sys.stdin: - foo = re.sub(r '^\\s*(?:[\\d.-]+g(\\S+)|([\\d.]+)\\+?[\\d]*)\\s+.*' , lambda m: m.group( 1 ) or m.group( 2 ), line) + foo = re.sub(r '^\\s*(?:[\\d.-]+g([a-zA-Z0-9]+)|([\\d.]+))(?:\\+[\\d]+)?\\s+.*' , lambda m: m.group( 1 ) or m.group( 2 ), line) if foo is line: sys.exit( 1 ) print(foo)
          Hide
          jhoblitt Joshua Hoblitt added a comment -

          The eups product version string parsing has been updated and manually tested to work with more formats. Additionally, a RUN_SCONS_CHECK parameter has been added to the tarball-matrix/tarball jobs to control running this "smoke" test.

          Show
          jhoblitt Joshua Hoblitt added a comment - The eups product version string parsing has been updated and manually tested to work with more formats. Additionally, a RUN_SCONS_CHECK parameter has been added to the tarball-matrix/tarball jobs to control running this "smoke" test.
          Hide
          jhoblitt Joshua Hoblitt added a comment -

          This appears to be well resolved.

          Show
          jhoblitt Joshua Hoblitt added a comment - This appears to be well resolved.

            People

            • Assignee:
              jhoblitt Joshua Hoblitt
              Reporter:
              jhoblitt Joshua Hoblitt
              Watchers:
              Frossie Economou, Joshua Hoblitt, Tim Jenness
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: