Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-12028

newinstall.sh should not set PATH unless miniconda is bootstraped

    XMLWordPrintable

    Details

      Description

      Craig Loomis [10:40 AM] 
      A fresh `https://raw.githubusercontent.com/lsst/lsst/master/scripts/newinstall.sh`, run without installing a miniconda, generates a loadLSST.bash which contains a troublesome `export PATH="/bin:${PATH}"`. Not entirely sure what is supposed to be happening with the `miniconda_path`, etc. variables in the use-user-anaconda case. MacOS 10.12, anaconda 4.4.0.
       
       
      Tim Jenness
      [10:42 AM] 
      @josh  I think you need to protect `export PATH="${miniconda_path}/bin:${PATH}"` so that it only happens if we installed miniconda. (edited)
       
       
      [10:43] 
      actually it’s this line sorry:
      ```local cmd_setup_miniconda="export PATH=\"${miniconda_path}/bin:\${PATH}\""```
      

        Attachments

          Activity

          Hide
          jhoblitt Joshua Hoblitt added a comment -

          PR opened on GH.

          Show
          jhoblitt Joshua Hoblitt added a comment - PR opened on GH.
          Hide
          tjenness Tim Jenness added a comment -

          Looks ok.

          Show
          tjenness Tim Jenness added a comment - Looks ok.
          Hide
          jhoblitt Joshua Hoblitt added a comment -

          Merged.

          Show
          jhoblitt Joshua Hoblitt added a comment - Merged.
          Hide
          jhoblitt Joshua Hoblitt added a comment -

          Re-opening this ticket as the EUPS_PKGROOT construction was broken by the first fix.

          Show
          jhoblitt Joshua Hoblitt added a comment - Re-opening this ticket as the EUPS_PKGROOT construction was broken by the first fix.
          Hide
          jhoblitt Joshua Hoblitt added a comment -

          A fix PR has been opened on GH.

          Show
          jhoblitt Joshua Hoblitt added a comment - A fix PR has been opened on GH.
          Hide
          jhoblitt Joshua Hoblitt added a comment -

          A re-fix has been merged.

          Show
          jhoblitt Joshua Hoblitt added a comment - A re-fix has been merged.

            People

            Assignee:
            jhoblitt Joshua Hoblitt
            Reporter:
            jhoblitt Joshua Hoblitt
            Reviewers:
            Tim Jenness
            Watchers:
            Joshua Hoblitt, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                CI Builds

                No builds found.