Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-12085

Camera geometry incorrect and outdated in obs_test

    Details

    • Story Points:
      1
    • Sprint:
      Alert Production F17 - 10
    • Team:
      Alert Production

      Description

      The optical distortion model is backwards.

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment - - edited

            I added a unit test for this to obs_base. That pull request is here https://github.com/lsst/obs_base/pull/71 (since the branch had not shown up in JIRA when I wrote this).

            Note that I fixed a few flake8 issues in obs_base cameraMapper.py (including one code error), but a code error remains that is being fixed in DM-12041

            Show
            rowen Russell Owen added a comment - - edited I added a unit test for this to obs_base. That pull request is here https://github.com/lsst/obs_base/pull/71 (since the branch had not shown up in JIRA when I wrote this). Note that I fixed a few flake8 issues in obs_base cameraMapper.py (including one code error), but a code error remains that is being fixed in DM-12041
            Hide
            Parejkoj John Parejko added a comment -

            Handful of comments in the PR, but it looks good in general.

            Show
            Parejkoj John Parejko added a comment - Handful of comments in the PR, but it looks good in general.
            Hide
            rowen Russell Owen added a comment -

            Thank you for the quick and helpful review. I adopted your suggestions.

            Show
            rowen Russell Owen added a comment - Thank you for the quick and helpful review. I adopted your suggestions.

              People

              • Assignee:
                rowen Russell Owen
                Reporter:
                rowen Russell Owen
                Reviewers:
                John Parejko
                Watchers:
                John Parejko, Russell Owen
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel