Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-12173

Update run comparison and color qa scripts to current APIs

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_analysis
    • Labels:
      None
    • Story Points:
      4
    • Epic Link:
    • Sprint:
      DRP F17-5
    • Team:
      Data Release Production

      Description

      While several updates have been made to the visit and coadd scripts, the run comparison and color analysis scripts have suffered some bitrot. Please update the visit and coadd run comparison scripts and the coadd color analysis script to current APIs.

        Attachments

          Issue Links

            Activity

            Hide
            lauren Lauren MacArthur added a comment -

            Might you have a moment to give this a quick look? I've fixed the butler issue you also came across for the comparison scripts and also made a number of other updates. All scripts seem to be in working order. You can have a look at the current status of the plots on tiger at Princeton at /tigress/HSC/HSC/rerun/lauren/LSST/working/cosmos/plots/. Note that for the "comparison" plots, I'm actually comparing the same run against itself (I didn't have two different recent runs handy, but I will do further testing on Hsin-Fang's weekly processing soon). Of interest though is for the visitComparison I applied the meas_mosaic results to only one, so these plots in particular show the uberCal correction fields on a per object basis for the mag and astrom comparisons, e.g.:
            /tigress/HSC/HSC/rerun/lauren/LSST/working/cosmos/plots/HSC-I/tract-9813/visit-1228/compareVisit-v1228-diff_base_GaussianFlux-sky-gals.png

            Show
            lauren Lauren MacArthur added a comment - Might you have a moment to give this a quick look? I've fixed the butler issue you also came across for the comparison scripts and also made a number of other updates. All scripts seem to be in working order. You can have a look at the current status of the plots on tiger at Princeton at /tigress/HSC/HSC/rerun/lauren/LSST/working/cosmos/plots/ . Note that for the "comparison" plots, I'm actually comparing the same run against itself (I didn't have two different recent runs handy, but I will do further testing on Hsin-Fang's weekly processing soon). Of interest though is for the visitComparison I applied the meas_mosaic results to only one, so these plots in particular show the uberCal correction fields on a per object basis for the mag and astrom comparisons, e.g.: /tigress/HSC/HSC/rerun/lauren/LSST/working/cosmos/plots/HSC-I/tract-9813/visit-1228/compareVisit-v1228-diff_base_GaussianFlux-sky-gals.png
            Hide
            price Paul Price added a comment -

            Review completed on GitHub.

            This needs a bit of cleanup before merging. In particular, some commits should be orthogonalised and there are a few features and refactorings I believe you should think about.

            Show
            price Paul Price added a comment - Review completed on GitHub . This needs a bit of cleanup before merging. In particular, some commits should be orthogonalised and there are a few features and refactorings I believe you should think about.
            Hide
            lauren Lauren MacArthur added a comment -

            Paul Price, I realize you marked this as reviewed, but your comments led to some significant changes and there were a few I pushed back on (see comments on the PR in github). Accordingly, I want to give you another chance to have a look at my changes and comments before I merge. Thanks again for such a thorough review.

            Show
            lauren Lauren MacArthur added a comment - Paul Price , I realize you marked this as reviewed, but your comments led to some significant changes and there were a few I pushed back on (see comments on the PR in github). Accordingly, I want to give you another chance to have a look at my changes and comments before I merge. Thanks again for such a thorough review.
            Hide
            price Paul Price added a comment -

            No need. (:

            Show
            price Paul Price added a comment - No need. (:

              People

              Assignee:
              lauren Lauren MacArthur
              Reporter:
              lauren Lauren MacArthur
              Reviewers:
              Paul Price
              Watchers:
              John Swinbank, Lauren MacArthur, Paul Price
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.