Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-12253

Port validate_drp to lsst.verify

    Details

      Description

      Port the validate_drp package to use the more current lsst.verify classes and persistence. This is corresponding with the updating of the jointcal package to use lsst.verify.

        Attachments

          Issue Links

            Activity

            krughoff Simon Krughoff created issue -
            krughoff Simon Krughoff made changes -
            Field Original Value New Value
            Epic Link DM-12002 [ 34605 ]
            krughoff Simon Krughoff made changes -
            Link This issue relates to DM-9534 [ DM-9534 ]
            krughoff Simon Krughoff made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            jsick Jonathan Sick made changes -
            Link This issue relates to DM-12269 [ DM-12269 ]
            jhoblitt Joshua Hoblitt made changes -
            Link This issue is triggering DM-12448 [ DM-12448 ]
            Hide
            krughoff Simon Krughoff added a comment -

            report_performance_master.rst is the ReST report generated by the master stack as of the closing of this ticket
            report_performance_verify_port.rst is the ReST report generated by the porting branch verify_port that resulted from the ticket branch for this issue

            Show
            krughoff Simon Krughoff added a comment - report_performance_master.rst is the ReST report generated by the master stack as of the closing of this ticket report_performance_verify_port.rst is the ReST report generated by the porting branch verify_port that resulted from the ticket branch for this issue
            krughoff Simon Krughoff made changes -
            Attachment report_performance_master.rst [ 30194 ]
            Attachment report_performance_verify_port.rst [ 30195 ]
            Hide
            krughoff Simon Krughoff added a comment -

            The code has been ported. I attach two versions of the report produced by reportPerformance.py. Some of the PA1 and PA2 numbers are slightly difference between the master version and the porting branch, but this is due to different random samples being picked between subsequent runs. This will be investigate more in DM-12570 to see if we should make measurements of those metrics deterministic.

            Note that the closing of this ticket does not indicate this has been merged to master. We are maintaining a longer running port branch, verify_port, to complete the porting including further testing between the port and master and for updating documentation.

            Show
            krughoff Simon Krughoff added a comment - The code has been ported. I attach two versions of the report produced by reportPerformance.py . Some of the PA1 and PA2 numbers are slightly difference between the master version and the porting branch, but this is due to different random samples being picked between subsequent runs. This will be investigate more in DM-12570 to see if we should make measurements of those metrics deterministic. Note that the closing of this ticket does not indicate this has been merged to master. We are maintaining a longer running port branch, verify_port , to complete the porting including further testing between the port and master and for updating documentation.
            krughoff Simon Krughoff made changes -
            Story Points 6 12
            krughoff Simon Krughoff made changes -
            Resolution Done [ 10000 ]
            Status In Progress [ 3 ] Done [ 10002 ]
            Hide
            krughoff Simon Krughoff added a comment -

            I'm hoping you'd be willing to give this a quick look. I missed it when I was merging the other branches. It's a +6-1 single commit PR.

            Show
            krughoff Simon Krughoff added a comment - I'm hoping you'd be willing to give this a quick look. I missed it when I was merging the other branches. It's a +6-1 single commit PR.
            krughoff Simon Krughoff made changes -
            Reviewers Jonathan Sick [ jsick ]
            Resolution Done [ 10000 ]
            Status Done [ 10002 ] In Review [ 10004 ]
            Hide
            jsick Jonathan Sick added a comment -

            Sweet.

            Show
            jsick Jonathan Sick added a comment - Sweet.
            jsick Jonathan Sick made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            Hide
            krughoff Simon Krughoff added a comment -

            Merged final commit in verify

            Show
            krughoff Simon Krughoff added a comment - Merged final commit in verify
            krughoff Simon Krughoff made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            Parejkoj John Parejko made changes -
            Link This issue is triggering DM-15208 [ DM-15208 ]

              People

              • Assignee:
                krughoff Simon Krughoff
                Reporter:
                krughoff Simon Krughoff
                Reviewers:
                Jonathan Sick
                Watchers:
                Jonathan Sick, Simon Krughoff
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel