Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-12254

Switch jointcal to default to IndexedRefObj instead of a.net

    XMLWordPrintable

    Details

      Description

      Jointcal currently defaults to using LoadAstrometryNetObjectsTask for its refObjLoader. This can be dangerous in that if one doesn't retarget in the config, loading the skyCircle will fail and getting to that point can take a long time with lots of files.

      We also plan to phase out A.Net catalogs over time, so this is a good idea long term as well. It does require some reconfiguration of the unittests however.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-11397 Remove twinkles1 jointcal testdata and tests

          • Done

          Improvement - An improvement or enhancement to an existing feature or task. DM-10242 Stop using astrometry_net by default

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            This will help me work with the HSC data in the meas_mosaic challenge.

            Show
            Parejkoj John Parejko added a comment - This will help me work with the HSC data in the meas_mosaic challenge.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Simon Krughoff, do you mind reviewing this change in RefObjLoaders?

            I also added auto-flake8 testing to pytest, per the instructions Tim Jenness put in the dev guide.

            Show
            Parejkoj John Parejko added a comment - Simon Krughoff , do you mind reviewing this change in RefObjLoaders? I also added auto-flake8 testing to pytest, per the instructions Tim Jenness put in the dev guide.
            Hide
            Permalink
            krughoff Simon Krughoff added a comment -

            I'll have a look. I'll try to get to it this afternoon.

            Show
            krughoff Simon Krughoff added a comment - I'll have a look. I'll try to get to it this afternoon.
            Hide
            Permalink
            krughoff Simon Krughoff added a comment -

            Merge.

            Show
            krughoff Simon Krughoff added a comment - Merge.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Thanks for the review.

            Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/26932/pipeline/

            Merged and done.

            Show
            Parejkoj John Parejko added a comment - Thanks for the review. Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/26932/pipeline/ Merged and done.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Simon Krughoff
              Watchers:
              Colin Slater, Jim Bosch, John Parejko, John Swinbank, Russell Owen, Simon Krughoff
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.