Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-12259

cleanup jointcal test warnings

    XMLWordPrintable

    Details

      Description

      Now that jointcal is running with full pytest-ness, there are a few runtime warnings that should be cleaned up.

      On Linux I see a bunch of these:

      tests/test_jointcal_hsc.py::JointcalTestHSC::test_jointcalTask_2_visits
        /home/parejkoj/lsst/lsstsw/stack/Linux64/meas_algorithms/13.0-24-g22030a45+3/python/lsst/meas/algorithms/astrometrySourceSelector.py:137: RuntimeWarning: invalid value encountered in greater
          return sourceCat.get(self.fluxKey)/sourceCat.get(self.fluxSigmaKey) > self.config.minSnr
      

      I thought I was seeing some other ones on macOS; I'll add them if I can confirm.

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            There was a discussion about these (well, similar ones) on slack a while back. This is a change to how numpy reports warnings when NaN is in a calculation, and pandas have been hit with this. See DM-11776.

            Show
            tjenness Tim Jenness added a comment - There was a discussion about these (well, similar ones) on slack a while back. This is a change to how numpy reports warnings when NaN is in a calculation, and pandas have been hit with this. See DM-11776 .
            Hide
            Parejkoj John Parejko added a comment -

            Yes, I think we might just use the {{np.errstate}] context manager to squash these, but I want to check whether they're important at all first.

            Show
            Parejkoj John Parejko added a comment - Yes, I think we might just use the {{np.errstate}] context manager to squash these, but I want to check whether they're important at all first.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Watchers:
              John Parejko, John Swinbank, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated: