# Image request is broken since FITS latest library update

XMLWordPrintable

## Details

• Type: Bug
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
• Story Points:
4
• Sprint:
SUIT Sprint 2017-10, SUIT Sprint 2017-11
• Team:
Science User Interface

## Description

In dev, since last FITS libraries update, i'm seeing problem to display some images.

The error i get in the server is:

 Request: WebPlotRequest:  edu.caltech.ipac.util.download.FailedRequestException: Could not create plot  at edu.caltech.ipac.firefly.server.visualize.WebPlotFactory.create(WebPlotFactory.java:190)  at edu.caltech.ipac.firefly.server.visualize.WebPlotFactory.createNew(WebPlotFactory.java:109)  at edu.caltech.ipac.firefly.server.visualize.VisServerOps.createPlot(VisServerOps.java:199)  at edu.caltech.ipac.firefly.server.visualize.VisServerOps.lambda$createPlotGroup$0(VisServerOps.java:148)  at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)  at java.util.concurrent.ThreadPoolExecutor\$Worker.run(ThreadPoolExecutor.java:617)  at java.lang.Thread.run(Thread.java:745) Caused by: java.lang.IllegalArgumentException: card not legal  at nom.tam.fits.HeaderCard.create(HeaderCard.java:176)  at nom.tam.fits.Header.(Header.java:212)  at edu.caltech.ipac.visualize.plot.FitsRead.cloneHeader(FitsRead.java:1741)  at edu.caltech.ipac.visualize.plot.FitsRead.getHeader(FitsRead.java:1619)  at edu.caltech.ipac.firefly.server.visualize.ImagePlotCreator.initPlotTitle(ImagePlotCreator.java:228)  at edu.caltech.ipac.firefly.server.visualize.ImagePlotCreator.createImagePlot(ImagePlotCreator.java:185)  at edu.caltech.ipac.firefly.server.visualize.ImagePlotCreator.makeAllNoBand(ImagePlotCreator.java:68)  at edu.caltech.ipac.firefly.server.visualize.ImagePlotBuilder.makeNewPlots(ImagePlotBuilder.java:296)  at edu.caltech.ipac.firefly.server.visualize.ImagePlotBuilder.build(ImagePlotBuilder.java:120)  at edu.caltech.ipac.firefly.server.visualize.WebPlotFactory.create(WebPlotFactory.java:145)  ... 6 more Caused by: java.io.EOFException  at nom.tam.util.BufferedDataInputStream.read(BufferedDataInputStream.java:183)  at nom.tam.fits.HeaderCard.readOneHeaderLine(HeaderCard.java:314)  at nom.tam.fits.HeaderCard.longStringCard(HeaderCard.java:1033)  at nom.tam.fits.HeaderCard.extractValueCommentFromString(HeaderCard.java:980)  at nom.tam.fits.HeaderCard.(HeaderCard.java:397)  at nom.tam.fits.HeaderCard.(HeaderCard.java:367)  at nom.tam.fits.HeaderCard.create(HeaderCard.java:174)

Step to reproduce:
Go to Firefly tri-view, make a search of WISE image on Single exposure ('4 band level1') and band 2. The image doesn't show up and error is thrown in the tomcat ouput.

(Unit tests regarding the FITS package have been failing lately too which is an indication of something broken in general with FITS reader)

## Activity

Hide
Gregory Dubois-Felsmann added a comment -

A pointer to the definition of the long-value convention in FITS files:
https://fits.gsfc.nasa.gov/registry/continue/continue.pdf

Note the clarification to one thing we were talking about yesterday: if a line containing a keyword value ending in "&" is not immediately followed by a CONTINUE line, the above standard says that the ampersand is to be treated as part of the keyword value (instead of being deleted). This rule would apply to the Herschel files that we looked at yesterday. Whether that is what the Herschel team intended when they wrote those files is another question.

Show
Gregory Dubois-Felsmann added a comment - A pointer to the definition of the long-value convention in FITS files: https://fits.gsfc.nasa.gov/registry/continue/continue.pdf Note the clarification to one thing we were talking about yesterday: if a line containing a keyword value ending in "&" is not immediately followed by a CONTINUE line, the above standard says that the ampersand is to be treated as part of the keyword value (instead of being deleted). This rule would apply to the Herschel files that we looked at yesterday. Whether that is what the Herschel team intended when they wrote those files is another question.
Hide
Cindy Wang [X] (Inactive) added a comment -

so per the document, 'continue.pdf', keyword LONGSTRN is recommended. As long as '&' and CONTINUE appears, it should be treated as long string no matter if LONGSTRN exists and where LONGSTRN is located in the header?

Show
Cindy Wang [X] (Inactive) added a comment - so per the document, 'continue.pdf', keyword LONGSTRN is recommended. As long as '&' and CONTINUE appears, it should be treated as long string no matter if LONGSTRN exists and where LONGSTRN is located in the header?

## People

• Assignee:
Cindy Wang [X] (Inactive)
Reporter:
Emmanuel Joliet
Reviewers:
Emmanuel Joliet, Trey Roby
Watchers:
Cindy Wang [X] (Inactive), Emmanuel Joliet, Gregory Dubois-Felsmann, Trey Roby, Xiuqin Wu [X] (Inactive)
0 Vote for this issue
Watchers:
5 Start watching this issue

## Dates

• Created:
Updated:
Resolved: