Details

    • Type: Technical task
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_tasks
    • Labels:
    • Story Points:
      2
    • Team:
      External

      Description

      Add high-level code to combine spatially-varying transmission curves during coaddition.

        Attachments

          Activity

          Hide
          jbosch Jim Bosch added a comment -

          Yusra AlSayyad, small review for you in coaddition code: propagating TransmissionCurves. Almost all of the heavy-lifting is on other tickets (DM-12370 is the only one still pending), so this is ticket is mostly test code.

           

          Show
          jbosch Jim Bosch added a comment - Yusra AlSayyad , small review for you in coaddition code: propagating TransmissionCurves. Almost all of the heavy-lifting is on other tickets ( DM-12370 is the only one still pending), so this is ticket is mostly test code.  
          Hide
          yusra Yusra AlSayyad added a comment - - edited

          Where can I find from lsst.meas.algorithms.testUtils import makeRandomTransmissionCurve? I didn't see a branch for this ticket in meas_algorithms and want to make sure I catch everything.

          Show
          yusra Yusra AlSayyad added a comment - - edited Where can I find from lsst.meas.algorithms.testUtils import makeRandomTransmissionCurve ? I didn't see a branch for this ticket in meas_algorithms and want to make sure I catch everything.
          Hide
          jbosch Jim Bosch added a comment - - edited

          That's on DM-12370 of meas_algorithms (also in review), which also provides makeCoaddTransmissionCurve itself.

          Show
          jbosch Jim Bosch added a comment - - edited That's on  DM-12370  of meas_algorithms (also in review), which also provides makeCoaddTransmissionCurve itself.
          Hide
          yusra Yusra AlSayyad added a comment -

          Looks good. Thanks for testing direct and psfMatched coadds. Why is doAttachTransmissionCurve=False by default?

          Show
          yusra Yusra AlSayyad added a comment - Looks good. Thanks for testing direct and psfMatched coadds. Why is doAttachTransmissionCurve=False by default?
          Hide
          jbosch Jim Bosch added a comment -

          Why is doAttachTransmissionCurve=False by default?

          We don't attach TransmissionCurves for most cameras during ISR (isr.doAttachTransmissionCurve also defaults to False), because nobody has compiled that data for anything other than HSC.

          An alternative would have been to make both of those steps leave the TransmissionCurve set to None when they don't have the necessary inputs.  But I wanted to guard against the case where someone is trying to build a coadd that includes TransmissionCurve propagation and doesn't realize until they get to the end that something went wrong in ISR; I don't feel like even warning helps much, and in any case I wouldn't want to make processing other cameras generate a lot of warnings.

          Will do one more Jenkins run with both DM-12370 and this before merging.

          Show
          jbosch Jim Bosch added a comment - Why is  doAttachTransmissionCurve=False  by default? We don't attach TransmissionCurves for most cameras during ISR ( isr.doAttachTransmissionCurve also defaults to False ), because nobody has compiled that data for anything other than HSC. An alternative would have been to make both of those steps leave the TransmissionCurve set to None when they don't have the necessary inputs.  But I wanted to guard against the case where someone is trying to build a coadd that includes TransmissionCurve propagation and doesn't realize until they get to the end that something went wrong in ISR; I don't feel like even warning helps much, and in any case I wouldn't want to make processing other cameras generate a lot of warnings. Will do one more Jenkins run with both DM-12370 and this before merging.

            People

            • Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Yusra AlSayyad
              Watchers:
              Jim Bosch, Yusra AlSayyad
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: