Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-12404

Update stack with new deblender API

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_deblender
    • Labels:
      None
    • Story Points:
      6
    • Epic Link:
    • Sprint:
      DRP F17-6, DRP S18-1, DRP S18-2, DRP S18-3, DRP S18-4, DRP S18-5
    • Team:
      Data Release Production

      Description

      Peter Melchior is updating the API for the 3rd party deblender, specifically changing the name of the package and improving the interface for adding peaks with multiple components and different constraints. Once that has been completed, this ticket will implement the improved API in the LSST stack.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-11553 Investigate drifting positions

          • Won't Fix

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-11554 Improve Block-SDMM convergence checks

          • Won't Fix
          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-12981 Create docstrings for updated deblender

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            fred3m Fred Moolekamp added a comment -

            Built successfully on Jenkins: https://ci.lsst.codes/job/stack-os-matrix/27726/

            Show
            fred3m Fred Moolekamp added a comment - Built successfully on Jenkins:  https://ci.lsst.codes/job/stack-os-matrix/27726/
            Hide
            Permalink
            fred3m Fred Moolekamp added a comment -

            Pim Schellart [X], you'll notice that there are two commits. Most of the development of the new deblender was done on the user branch u/fred/deblender over the past year, but a large portion of that work is obsolete and no longer necessary for the merge to master. The user branch is still active to keep a history of the code changes that lead to the current work, so the first commit is just a patch that applies all the changes made over the past year, which is almost entirely the work you already reviewed in DM-11329.

            So you should be able to just check the second commit, which contains all of the changes.

            Show
            fred3m Fred Moolekamp added a comment - Pim Schellart [X] , you'll notice that there are two commits. Most of the development of the new deblender was done on the user branch u/fred/deblender over the past year, but a large portion of that work is obsolete and no longer necessary for the merge to master. The user branch is still active to keep a history of the code changes that lead to the current work, so the first commit is just a patch that applies all the changes made over the past year, which is almost entirely the work you already reviewed in DM-11329 . So you should be able to just check the second commit, which contains all of the changes.
            Hide
            Permalink
            pschella Pim Schellart [X] (Inactive) added a comment -

            Minor clarifications requested/suggested on PR. Otherwise good to go.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Minor clarifications requested/suggested on PR. Otherwise good to go.

              People

              Assignee:
              fred3m Fred Moolekamp
              Reporter:
              fred3m Fred Moolekamp
              Reviewers:
              Pim Schellart [X] (Inactive)
              Watchers:
              Fred Moolekamp, Pim Schellart [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.